fix: canonical request path if empty choose '/' #1165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
force-pushed
the
fix-canonical
branch
from
35eba01 to
a425458
Compare
harshavardhana
force-pushed
the
fix-canonical
branch
from
a425458 to
cae1652
Compare
SignatureV4 has no empty paths as part of canonical request, at the minimum it must be `/`. additionally this PR allows content-type and content-length to be part of signed headers as this is allowed in signature v4.
harshavardhana
force-pushed
the
fix-canonical
branch
from
cae1652 to
87f61f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
additionally this PR allows content-type and
content-length to be part of signed headers as
this is allowed in signature v4.