Skip to content
This repository was archived by the owner on Mar 20, 2026. It is now read-only.

Add support for custom environment variables on all services#1174

Merged
cniackz merged 1 commit intominio:masterfrom
Alevsk:env-var-fields-services
Jun 19, 2022
Merged

Add support for custom environment variables on all services#1174
cniackz merged 1 commit intominio:masterfrom
Alevsk:env-var-fields-services

Conversation

@Alevsk
Copy link
Copy Markdown
Contributor

@Alevsk Alevsk commented Jun 17, 2022

  • added env field to log search api, prometheus, postgres and kes
    services
  • added env field to tenant helm chart
  • fixed tenant unnecessary rollout restart everytime a change is
    applied, annotation kubectl.kubernetes.io/last-applied-configuration changes
    with every update triggering the minio pods restart
  • fixed rollout restart issue for minio statefulsets

Signed-off-by: Lenin Alevski alevsk.8772@gmail.com

@Alevsk Alevsk self-assigned this Jun 17, 2022
@Alevsk Alevsk added the wip label Jun 17, 2022
@Alevsk Alevsk changed the title Add support for custom environment variables on all services [WIP] Add support for custom environment variables on all services Jun 17, 2022
@Alevsk Alevsk force-pushed the env-var-fields-services branch from 5e074d7 to ecd7455 Compare June 17, 2022 18:32
@Alevsk Alevsk changed the title [WIP] Add support for custom environment variables on all services Add support for custom environment variables on all services Jun 17, 2022
@Alevsk Alevsk removed the wip label Jun 17, 2022
@Alevsk Alevsk changed the title Add support for custom environment variables on all services [WIP] Add support for custom environment variables on all services Jun 17, 2022
@Alevsk Alevsk added wip and removed wip labels Jun 17, 2022
@Alevsk Alevsk changed the title [WIP] Add support for custom environment variables on all services Add support for custom environment variables on all services Jun 17, 2022
@Alevsk Alevsk changed the title Add support for custom environment variables on all services [ WIP] Add support for custom environment variables on all services Jun 17, 2022
@Alevsk Alevsk force-pushed the env-var-fields-services branch from ecd7455 to 786d12b Compare June 17, 2022 20:17
@Alevsk Alevsk changed the title [ WIP] Add support for custom environment variables on all services Add support for custom environment variables on all services Jun 17, 2022
@Alevsk Alevsk force-pushed the env-var-fields-services branch from 786d12b to d74e85a Compare June 17, 2022 20:19
Comment thread pkg/controller/cluster/pools.go
- added env field to log search api, prometheus, postgres and kes
  services
- added env field to tenant helm chart
- fixed tenant unnecessary rollout restart everytime a change is
  applied, annotation kubectl.kubernetes.io/last-applied-configuration changes
  with every update triggering the minio pods restart
- fixed rollout restart issue for minio statefulsets

Signed-off-by: Lenin Alevski <alevsk.8772@gmail.com>
@Alevsk Alevsk force-pushed the env-var-fields-services branch from d74e85a to e5545be Compare June 18, 2022 01:52
@Alevsk Alevsk requested a review from harshavardhana June 18, 2022 01:52
Copy link
Copy Markdown
Contributor

@cniackz cniackz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cniackz cniackz merged commit 1dd2b9b into minio:master Jun 19, 2022
@Alevsk Alevsk deleted the env-var-fields-services branch June 19, 2022 22:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants