Skip to content
This repository was archived by the owner on Mar 20, 2026. It is now read-only.

Using container image digests from RedHat Registry#1241

Merged
harshavardhana merged 1 commit intominio:masterfrom
cniackz:use-sha-from-redhat-registry
Aug 17, 2022
Merged

Using container image digests from RedHat Registry#1241
harshavardhana merged 1 commit intominio:masterfrom
cniackz:use-sha-from-redhat-registry

Conversation

@cniackz
Copy link
Copy Markdown
Contributor

@cniackz cniackz commented Aug 16, 2022 •
edited
Loading

The reason for this PR, it is to properly get the digests from Console Image, as with current option, there will be no match and hence updating the catalogs will continue to fail:

$ docker pull minio/console:v0.19.4
v0.19.4: Pulling from minio/console
Digest: sha256:930dc08dac5bad399e3e2af17d72e1e9c4ec1e8c8d6dedc83c4f685a47adaeb3 <--- Different than we need to update RedHat Catalogs.
Status: Image is up to date for minio/console:v0.19.4
docker.io/minio/console:v0.19.4

$ docker pull quay.io/minio/console:v0.19.4
v0.19.4: Pulling from minio/console
Digest: sha256:148331d40fd34a6b96a5f70acfd71e1d870b588a7b3ff6b646a0056d55ad5e9b <--- The one we need to update RedHat Catalogs.
Status: Downloaded newer image for quay.io/minio/console:v0.19.4
quay.io/minio/console:v0.19.4

Notice we introduced these lines specifically for RedHat repositories:

  1. https://github.com/redhat-openshift-ecosystem/certified-operators
  2. https://github.com/redhat-openshift-ecosystem/redhat-marketplace-operators

So quay.io registry is a must in those repositories for OLM to deploy our Operator while in the verification process.

@cniackz cniackz self-assigned this Aug 16, 2022
@cniackz cniackz added bug Something isn't working fixed labels Aug 16, 2022
@harshavardhana harshavardhana merged commit 0f187b4 into minio:master Aug 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Alevsk Alevsk Awaiting requested review from Alevsk

@bexsoft bexsoft Awaiting requested review from bexsoft

@dvaldivia dvaldivia Awaiting requested review from dvaldivia

@jinapurapu jinapurapu Awaiting requested review from jinapurapu

@prakashsvmx prakashsvmx Awaiting requested review from prakashsvmx

4 more reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@pjuarezd pjuarezd pjuarezd approved these changes

@Praveenrajmani Praveenrajmani Praveenrajmani approved these changes

@reivaj05 reivaj05 reivaj05 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cniackz cniackz

Labels

bug Something isn't working fixed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cniackz @harshavardhana @pjuarezd @Praveenrajmani @reivaj05