This repository was archived by the owner on Mar 20, 2026. It is now read-only.
Use k8s recorder for events#1242
Merged
dvaldivia merged 1 commit intominio:masterfrom Aug 17, 2022
Merged
Conversation
reivaj05
requested review from
Alevsk,
bexsoft,
cniackz,
dvaldivia,
harshavardhana and
pjuarezd
Collaborator
|
It was that easy?! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use k8s recorder implementation to create and update events.
Closes: https://github.com/miniohq/engineering/issues/705
It will better handle the creation of events.
First events were created with previous implementation and last line with the change
