This repository was archived by the owner on Mar 20, 2026. It is now read-only.
fix: function name typo#1247
Merged
harshavardhana merged 1 commit intominio:masterfrom Aug 22, 2022
wanglei4687:fix-func-typo
Merged
fix: function name typo#1247harshavardhana merged 1 commit intominio:masterfrom wanglei4687:fix-func-typo
harshavardhana merged 1 commit intominio:masterfrom
wanglei4687:fix-func-typo
Conversation
Signed-off-by: wanglei4687 <wanglei4687@gmail.com>
cniackz
approved these changes
Aug 22, 2022
Contributor
cniackz
left a comment
cniackz
left a comment
There was a problem hiding this comment.
It looks good to me; all spots covered for typo:
$ grep -R 'serializeJSONPachOps'
./kubectl-minio/cmd/init.go: Patch: o.serializeJSONPachOps(operatorDepPatches),
./kubectl-minio/cmd/init.go: Patch: o.serializeJSONPachOps([]interface{}{
./kubectl-minio/cmd/init.go:func (o *operatorInitCmd) serializeJSONPachOps(jp []interface{}) string {
reivaj05
approved these changes
Aug 22, 2022
harshavardhana
approved these changes
Aug 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: wanglei4687 wanglei4687@gmail.com
Description
Scope:
kubectl-minio/cmd/initfunction name
serializeJSONPachOpsshould beserializeJSONPatchOps