This repository was archived by the owner on Mar 20, 2026. It is now read-only.
Add Startup Probe to Tenant#1315
Merged
dvaldivia merged 1 commit intominio:masterfrom Oct 13, 2022
Merged
Conversation
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
dvaldivia
requested review from
Alevsk,
bexsoft,
cniackz,
dilverse,
harshavardhana,
pjuarezd and
reivaj05
Collaborator
Author
|
heads up @hrenard I'm reverting your change in favor of a more configurable approach |
Alevsk
approved these changes
Oct 12, 2022
bexsoft
approved these changes
Oct 13, 2022
Contributor
|
Thanks for the heads-up ! I think that a startupProbeTimeout and a disableStartupProbe options is a better user experience. For me an operator should abstract some knowledge (like the startup probe endpoint) to reduce the risk of a user config breaking from one version to another. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a configurable Startup Probe at tenant level which in turns gets passed to each pool and pod.
Essentially reverts #1284 since we ran into problems where startup time was longer than the hardcoded 30 seconds which ended up killing the pods, there's a known issue on GKE that causes pods to take up to 10 minutes to start if they are lacking a readiness endpoint and mixed with GKE load balancers. thus we need a configurable startup probe rather than a defaulted one.
Signed-off-by: Daniel Valdivia 18384552+dvaldivia@users.noreply.github.com