This repository was archived by the owner on Mar 20, 2026. It is now read-only.
fix:error should be handled#1334
Merged
pjuarezd merged 1 commit intominio:masterfrom Nov 1, 2022
Merged
Conversation
If it is a network error, nil should not be returned here
dilverse
approved these changes
Nov 1, 2022
pjuarezd
approved these changes
Nov 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If it is a network error, nil should not be returned here.
tenant, err := c.minioClientSet.MinioV2().Tenants(namespace).Get(context.Background(), tenantName, metav1.GetOptions{}) if err != nil { // The Tenant resource may no longer exist, in which case we stop processing. if k8serrors.IsNotFound(err) { runtime.HandleError(fmt.Errorf("Tenant '%s' in work queue no longer exists", key)) return nil } - return nil + return err }