Generate CRD docs using local code path#519
Merged
harshavardhana merged 1 commit intomasterfrom Mar 9, 2021
Merged
Conversation
harshavardhana
previously approved these changes
Mar 5, 2021
dvaldivia
previously approved these changes
Mar 5, 2021
I had some issues getting my GOPATH set up and tried pointing the CRD generator right at the v2 API files. And it worked, so we might as well make this a long-term change. Pointing at V2 only since V1 is deprecated. In the updated CRD reference I'll explicitly point users to the 3.0.29 tag for v1 CRD docs. Please test this locally to ensure it works - it should have no impact on non-doc operator functionality, but it's better safe than sorry.
ravindk89
force-pushed
the
crd-generator-path-update
branch
from
7a4da34 to
f2bbc79
Compare
dvaldivia
approved these changes
Mar 8, 2021
Contributor
Author
|
@harshavardhana I had to force-push + rebase to fix some merge commits, can you do a cursory approve? |
harshavardhana
approved these changes
Mar 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had some issues getting my GOPATH set up and tried pointing the CRD generator right at the v2 API files. And it worked, so we might as well make this a long-term change.
Pointing at V2 only since V1 is deprecated. In the updated CRD reference I'll explicitly point users to the 3.0.29 tag for v1 CRD docs.
Please test this locally to ensure it works - it should have no impact on non-doc operator functionality, but it's better safe than sorry.