Add configurable Prometheus image option#522
Merged
dvaldivia merged 1 commit intominio:masterfrom Mar 8, 2021
nitisht:config-prom
Merged
Add configurable Prometheus image option#522dvaldivia merged 1 commit intominio:masterfrom nitisht:config-prom
dvaldivia merged 1 commit intominio:masterfrom
nitisht:config-prom
Conversation
harshavardhana
approved these changes
Mar 6, 2021
dvaldivia
reviewed
Mar 8, 2021
| // SideCarImage defines container image to be used for sidecar | ||
| // Expects "alpine" image | ||
| // +optional | ||
| SideCarImage string `json:"sidecarimage,omitempty"` |
Collaborator
There was a problem hiding this comment.
I think sidecars should be an array of Container's, similar to what we did for zones, that way if they need more sidecars it's easier to add
dvaldivia
approved these changes
Mar 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.