Skip to content

add ParseTimeDuration to support day format#117

Merged
harshavardhana merged 11 commits intominio:mainfrom
jiuker:add_ParseTimeDurationSimply
Jul 6, 2024
Merged

add ParseTimeDuration to support day format#117
harshavardhana merged 11 commits intominio:mainfrom
jiuker:add_ParseTimeDurationSimply

Conversation

@jiuker
Copy link
Copy Markdown
Contributor

@jiuker jiuker commented Jul 5, 2024

add time.Parse to support day
to support 7d12h

Comment thread time/time.go Outdated
Comment thread time/time.go Outdated
jiuker added 2 commits July 5, 2024 15:20
apply suggestion
apply suggesiton
@jiuker jiuker requested a review from harshavardhana July 5, 2024 07:21
@jiuker
Copy link
Copy Markdown
Contributor Author

jiuker commented Jul 5, 2024

@harshavardhana shall we limit the 100h or 500m?

vulncheck
@jiuker jiuker changed the title add time.Parse to support day add ParseTimeDuration to support day format Jul 5, 2024
jiuker added 2 commits July 6, 2024 21:49
refactor
support float
apply suggestion
Comment thread time/time.go Outdated
apply suggestion
@jiuker jiuker requested a review from harshavardhana July 6, 2024 13:59
jiuker and others added 2 commits July 6, 2024 22:04
@harshavardhana harshavardhana force-pushed the add_ParseTimeDurationSimply branch from c162ccc to fa88ad9 Compare July 6, 2024 16:12
@harshavardhana harshavardhana merged commit b96a668 into minio:main Jul 6, 2024
@jiuker
Copy link
Copy Markdown
Contributor Author

jiuker commented Jul 7, 2024

cool
@harshavardhana

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants