Add DecodeDN#119
Merged
harshavardhana merged 5 commits intominio:mainfrom Jul 9, 2024
Merged
Conversation
harshavardhana
requested changes
Jul 8, 2024
Contributor
Author
|
All changes should be there |
donatello
approved these changes
Jul 8, 2024
Member
donatello
left a comment
donatello
left a comment
There was a problem hiding this comment.
LGTM - though we should rename ldap/decode_test.go to `ldap/decode_dn_contrib_test.go
Contributor
Author
|
Forgot about that, fixed |
harshavardhana
approved these changes
Jul 9, 2024
| "fmt" | ||
| "testing" | ||
| ) | ||
|
|
Member
There was a problem hiding this comment.
No this file doesn't need to renamed() this test is entire written by us so its under our copyright not a _contrib @taran-p @donatello
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds DecodeDN to ldap package