Allow a KMS Action to specify keys in the Resources of a policy#121
Merged
harshavardhana merged 8 commits intominio:mainfrom Jul 15, 2024
Merged
Allow a KMS Action to specify keys in the Resources of a policy#121harshavardhana merged 8 commits intominio:mainfrom
harshavardhana merged 8 commits intominio:mainfrom
Conversation
marktheunissen
commented
Jul 12, 2024
marktheunissen
changed the title
8 tasks
harshavardhana
requested changes
Jul 12, 2024
Co-authored-by: Harshavardhana <harsha@minio.io>
Co-authored-by: Harshavardhana <harsha@minio.io>
Contributor
Author
|
Should be good to go, all feedback implemented 👍 Not 100% sure if "unknownARN" is being used in the way you intended. LMK how else it might be used. |
harshavardhana
requested changes
Jul 12, 2024
klauspost
reviewed
Jul 12, 2024
Contributor
klauspost
left a comment
klauspost
left a comment
There was a problem hiding this comment.
Just some minor tweaks.
harshavardhana
approved these changes
Jul 15, 2024
klauspost
approved these changes
Jul 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.