add --metadata and --tag during put operations#349
Merged
harshavardhana merged 1 commit intominio:masterfrom Nov 29, 2024
Merged
add --metadata and --tag during put operations#349harshavardhana merged 1 commit intominio:masterfrom
harshavardhana merged 1 commit intominio:masterfrom
Conversation
fatpat
force-pushed
the
put-metadatas
branch
from
02a969a to
c907159
Compare
klauspost
reviewed
Nov 19, 2024
Collaborator
klauspost
left a comment
klauspost
left a comment
There was a problem hiding this comment.
Very fringe. Make the flag hidden.
fatpat
force-pushed
the
put-metadatas
branch
2 times, most recently
from
77c0e44 to
68a80a5
Compare
fatpat
changed the title
klauspost
approved these changes
Nov 19, 2024
fatpat
force-pushed
the
put-metadatas
branch
from
68a80a5 to
7417d6e
Compare
klauspost
reviewed
Nov 19, 2024
Collaborator
klauspost
left a comment
klauspost
left a comment
There was a problem hiding this comment.
A few linter issues and a conflict. Merge master to resolve the ones unrelated to your code.
fatpat
force-pushed
the
put-metadatas
branch
from
7417d6e to
21f203a
Compare
Collaborator
|
Please address the linter issues remaining in your code, and we should be good. |
fatpat
force-pushed
the
put-metadatas
branch
from
21f203a to
9728e3e
Compare
harshavardhana
added a commit
to harshavardhana/warp
that referenced
this pull request
Dec 23, 2024
A regression caused by minio#349
harshavardhana
added a commit
that referenced
this pull request
Dec 23, 2024
A regression caused by #349
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--metadata key=valueflag allow to set user metadata during write operations.--tag key=valueflag allow to set user tag during write operations.this can be used to test some S3 services with more complex scenarios