Support larger runs (thread IDs uint16 => uint32)#428
Merged
harshavardhana merged 2 commits intominio:masterfrom Nov 20, 2025
Merged
Support larger runs (thread IDs uint16 => uint32)#428harshavardhana merged 2 commits intominio:masterfrom
harshavardhana merged 2 commits intominio:masterfrom
Conversation
klauspost
reviewed
Nov 19, 2025
dbishop
force-pushed
the
thread-id-to-uint32
branch
from
3e27895 to
748cd9d
Compare
We hit the limit for thread cardinality in a large object storage benchmark run (500 hosts, 192 concurrency). This patch bumps the thread ID data type from uint16 to uint32 to support larger runs. Also added an "Assistant workflow for linting" section to CLAUDE.md to induce efficient auto-formatting and linting. This, combined with the added .cursorrules file, helped me with using Cursor with Warp. The .cursorrules contents mostly delegate to CLAUDE.md to not repeat tool guidance/context-compression. Tweaked the Core Components section of CLAUDE.md to help guide import understanding. I had Cursor unnecessarily stumble into circular dependencies, so this should help with that. Clarified the CSV format in CLAUDE.md.
dbishop
force-pushed
the
thread-id-to-uint32
branch
from
748cd9d to
11f897f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
Fix inability to perform larger runs (thread IDs uint16 => uint32)
Also added an "Assistant workflow for linting" section to CLAUDE.md to induce efficient auto-formatting and linting. This, combined with the added .cursorrules file, helped me with using Cursor with Warp. The .cursorrules contents mostly delegate to CLAUDE.md to not repeat tool guidance/context-compression.
Tweaked the Core Components section of CLAUDE.md to help guide import understanding. I had Cursor unnecessarily stumble into circular dependencies, so this should help with that.
Clarified the CSV format in CLAUDE.md.
Motivation and Context
We hit the limit for thread cardinality in a large object storage benchmark run (500 hosts, 192 concurrency). This patch bumps the thread ID data type from uint16 to uint32 to support larger runs.
For the CLAUDE.md/.cursorrules changes, I found those to be useful in my Cursor workflow. I haven't tested their effect on Claude Code, but I would expect them to also be beneficial there as well.
How to test this PR?
This will be difficult, but our patched and built Warp binary did work. Technically, this was a different patch against an older version of Warp, but it was the same semantic change.
Types of changes
Checklist:
commit-idorPR #here)