Skip to content

Fix terminal state on exit when Prepare fails.#429

Merged
harshavardhana merged 1 commit intominio:masterfrom
dbishop:issue-371
Nov 19, 2025
Merged

Fix terminal state on exit when Prepare fails.#429
harshavardhana merged 1 commit intominio:masterfrom
dbishop:issue-371

Conversation

@dbishop
Copy link
Contributor

@dbishop dbishop commented Nov 18, 2025

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

Clean up terminal state when Prepare fails before exiting.

Motivation and Context

I'm not sure, but this could be the same issue as #371

I noticed my terminal getting messed up when running "warp delete" on a bucket that happened to be empty, making me have to run "reset".

This patch fixed the issue for me.

How to test this PR?

I've been carrying this patch around a while, so I don't have a recent repro case to share. But what I was doing at the time was running "warp delete" with --list-existing against buckets that were already empty with some concurrency (unsure if that's required to trigger the issue).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

I'm not sure, but this could be the same issue as
minio#371

I noticed my terminal getting messed up when running "warp delete" on a
bucket that happened to be empty, making me have to run "reset".

This patch fixed the issue for me.
Copy link
Collaborator

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@harshavardhana harshavardhana merged commit 88041bc into minio:master Nov 19, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants