Fix terminal state on exit when Prepare fails.#429
Merged
harshavardhana merged 1 commit intominio:masterfrom Nov 19, 2025
Merged
Fix terminal state on exit when Prepare fails.#429harshavardhana merged 1 commit intominio:masterfrom
harshavardhana merged 1 commit intominio:masterfrom
Conversation
I'm not sure, but this could be the same issue as minio#371 I noticed my terminal getting messed up when running "warp delete" on a bucket that happened to be empty, making me have to run "reset". This patch fixed the issue for me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
Clean up terminal state when Prepare fails before exiting.
Motivation and Context
I'm not sure, but this could be the same issue as #371
I noticed my terminal getting messed up when running "warp delete" on a bucket that happened to be empty, making me have to run "reset".
This patch fixed the issue for me.
How to test this PR?
I've been carrying this patch around a while, so I don't have a recent repro case to share. But what I was doing at the time was running "warp delete" with --list-existing against buckets that were already empty with some concurrency (unsure if that's required to trigger the issue).
Types of changes
Checklist: