Move prefix generation from Object to Options#435
Merged
klauspost merged 2 commits intominio:masterfrom Dec 18, 2025
Merged
Conversation
Move prefix generation logic from Object.setPrefix(Options) to Options.GeneratePrefix(), improving separation of concerns: - Add Options.GeneratePrefix() method in options.go - Update randomSrc to set Prefix directly from GeneratePrefix() - Remove Object.setPrefix() method from generator.go Object no longer needs knowledge of Options internals.
klauspost
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
Move prefix generation logic from Object.setPrefix(Options) to Options.GeneratePrefix(), improving separation of concerns:
Object no longer needs knowledge of Options internals.
Motivation and Context
Better separation of concerns makes the object prefix easier to reason about, test (if necessary), and maintain patches against (if necessary).
Broken out of #432
How to test this PR?
Any standard regression testing; should cover no flags, just --prefix, just --noprefix and --prefix and --noprefix.
Types of changes
Checklist:
commit-idorPR #here)