Distributed delete runs no longer overlap#441
Merged
klauspost merged 2 commits intominio:masterfrom Dec 29, 2025
Merged
Conversation
Previously, when a distributed (more than one client) delete benchmark deleted objects with --list-existing, all clients would try to delete all objects. This resulted in a lot of spurious errors. This patch makes each client only delete a partition (based on a hash of the object path) of the full object list. This patch does NOT try to address the server and all clients trying to run Cleanup() for non-delete benchmark types. That is to say, this patch does not mess with Common.deleteAllInBucket().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
This patch makes each client only delete a partition (based on a hash of the object path) of the full object list.
This patch does NOT try to address the server and all clients trying to run Cleanup() for non-delete benchmark types. That is to say, this patch does not mess with Common.deleteAllInBucket().
Motivation and Context
Previously, when a distributed (more than one client) delete benchmark deleted objects with --list-existing, all clients would try to delete all objects. This resulted in a lot of spurious errors.
This fix doesn't same much wall time, but it will lower load on the object storage system and keeps the logs cleaner.
How to test this PR?
There may be other ways to trigger the errors, but we we do is run a final delete with --list-existing (after separate PUT and GET phases).
Types of changes
Checklist:
commit-idorPR #here)