handle generator exhaustion in the scheduler - #256
Open
sneakers-the-rat wants to merge 5 commits into
Open
Conversation
Merging this PR will improve performance by 10.49%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | test_kitchen_sink_run[SynchronousRunner-testing-kitchen-sink] |
10.3 ms | 9.3 ms | +10.49% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing generator-exhaustion (4773f64) with main (d5bea76)
Footnotes
-
8 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
sneakers-the-rat
marked this pull request as ready for review
August 4, 2026 01:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #147 , supercedes #248
Handle generator exhaustion but in the scheduler this time, now that we have noob-core.
allows nodes to emit an
Exhaustionmeta-signal, which effectively allows them to self-disable. any remaining scheduled work can continue, but subsequent calls to try and run the generator once it's exhausted throws an error.handling this in the scheduler is better than in the runners so we don't have to add a ton more state to each of the runners, and this also allows us to have a fine-grained understanding of exhaustion, where tubes that have a generator within them that can exhaust while the tube still has meaningful work to do can exist.
i just want to take a moment to laugh at what the LLM would have had us do instead, first commit in 248, which is a very concrete example of how the LLM would have done a technically working but not very general implementation: each runner needed its own implementation, it was special-cased for generators rather than something any any node would be able to emit, it wasn't finely scoped to individual nodes, wouldn't have allowed in-progress work to complete, and was just in general shitty.
📚 Documentation preview 📚: https://noob--256.org.readthedocs.build/en/256/