Preserve compact runtime defaults while opening edit-guidance opt-in - #126
Merged
Merged
Conversation
The runtime path needs a safe way to request line-aware patch targets later without changing today's automatic pre-read behavior. This adds a narrow pre-read options seam and locks default Codex runtime/wrapper behavior with regression coverage. Public wording now keeps runtime edit-guidance and provider billing evidence claims separated for release readiness. Constraint: Public-source timing requires small verified changes and strict claim boundaries Rejected: Wire runtime editGuidance automatically now | edit-intent and positive freshness gates are not implemented in this PR Rejected: Bundle provider tokenizer/billing proof | tracked separately in issue #108 Confidence: high Scope-risk: narrow Directive: Do not pass includeEditGuidance from runtime hooks without exact-file edit intent, positive freshness, fingerprint equality, payload-budget tests, and negative prompt coverage Tested: npm run build Tested: npm run typecheck Tested: npm run lint Tested: node --test test/fooks.test.mjs test/runtime-bridge-contract.test.mjs Tested: npm test Tested: npm run release:smoke Related: #108
This was referenced Apr 23, 2026
minislively
added a commit
that referenced
this pull request
May 14, 2026
…126) The runtime path needs a safe way to request line-aware patch targets later without changing today's automatic pre-read behavior. This adds a narrow pre-read options seam and locks default Codex runtime/wrapper behavior with regression coverage. Public wording now keeps runtime edit-guidance and provider billing evidence claims separated for release readiness. Constraint: Public-source timing requires small verified changes and strict claim boundaries Rejected: Wire runtime editGuidance automatically now | edit-intent and positive freshness gates are not implemented in this PR Rejected: Bundle provider tokenizer/billing proof | tracked separately in issue #108 Confidence: high Scope-risk: narrow Directive: Do not pass includeEditGuidance from runtime hooks without exact-file edit intent, positive freshness, fingerprint equality, payload-budget tests, and negative prompt coverage Tested: npm run build Tested: npm run typecheck Tested: npm run lint Tested: node --test test/fooks.test.mjs test/runtime-bridge-contract.test.mjs Tested: npm test Tested: npm run release:smoke Related: #108 Co-authored-by: minislively <minislively@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
decidePreRead(..., options?)seam for explicitincludeEditGuidanceopt-ineditGuidanceScope boundary
This PR intentionally does not wire runtime hooks to auto-include
editGuidance. Runtime opt-in remains blocked until exact-file frontend edit intent, positive freshness, fingerprint equality, and payload-budget safety are implemented with positive/negative tests.This PR also does not implement provider tokenizer proof, provider billing-token proof, provider-cost proof, LSP semantics, or live Codex/Claude outcome claims.
Verification
npm run buildnpm run typechecknpm run lintnode --test test/fooks.test.mjs test/runtime-bridge-contract.test.mjsnpm testnpm run release:smokeRelated