browserstack integration#65
browserstack integration#65nidhimj22 wants to merge 3 commits intominkphp:masterfrom nidhimj22:master
Conversation
|
Don't we have mentions of BrowserStack anywhere else? |
|
|
||
| Check out `BrowserStack's repository`_ for an example integration with BrowserStack. | ||
|
|
||
| .. _BrowserStack's repository: https://github.com/browserstack/behat-mink-browserstack |
There was a problem hiding this comment.
That page doesn't look too helpful. Maybe reference BrowserStack documentation for WebDriver integration instead.
There was a problem hiding this comment.
I've meant BrowserStack website: https://www.browserstack.com/automate/capabilities
There was a problem hiding this comment.
I've added the website link also. Let me know if this looks good
There was a problem hiding this comment.
I've meant instead of https://github.com/browserstack/behat-mink-browserstack use https://www.browserstack.com/automate/capabilities
There was a problem hiding this comment.
yes, but don't you feel that the integration is more specific to the Mink extension and can be cloned and run making it easier for the users?
Let me know if you still want me to make the change.
|
No, there is no BrowserStack reference anywhere else in the documentation. |
|
I think you're submitting PR to wrong place. The Mink itself doesn't have any BrowserStack integration. It has MinkSelenium2Driver that can talk WebDriver protocol that in turn can be used to talk to BrowserStack and Sauce Labs. The libraries that use Mink have integration with BrowserStack and Sauce Labs, e.g.
And it's there documentation where change is needed if BrowserStack/Sauce Labs aren't mentioned in there. Since the repo you're trying to reference (https://github.com/browserstack/behat-mink-browserstack) is using The http://phpunit-mink.readthedocs.io/en/latest/getting-started.html page of PHPUnit-Mink documentation already describes show to configure it to be used with both BrowserStack and Sauce Labs. |
|
Yes, makes sense. |
|
I'm not watching Behat repo, but I've just noticed that you're already send appropriate PR to Behat docs repo at Behat/docs#99 . I'll close this PR then. |
Added Documentation for integrating with browserStack