fix(coding-agent): keep compaction progress bounded#3
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
Important Review skippedAuto reviews are disabled on this repository. To trigger a review, include ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Superseded by standalone upstream Draft PR code-yeongyu#322. The replacement is based directly on upstream main and contains only the bounded compaction progress preview fix. |
Summary
Problem
compaction_progresspreviously rendered up to 4,000 characters of accumulated summary text through multilineTextinsidestatusContainer, immediately above the editor. As the summary streamed, every newline increased rootheight, moved the composer, and pushed prior transcript rows into scrollback. In a normal terminal this looked like the
input box followed the summary upward and previous output was erased.
Fix
TruncatedTextTests
"live summary\nchunk"produced loader plus two preview rowsValidation:
npm run check: passedgit diff --check: passedManual QA
Browser-rendered xterm.js at 80×24:
Browser-rendered xterm.js at 50×16:
Real source channels:
Review
Independent goal, hands-on QA, code quality, security, visual fidelity, and stacked/upstream-context reviewers all
returned PASS with no blockers.
Summary by cubic
Bound the streamed compaction progress preview to a single row to prevent terminal viewport jumps during compaction. Keeps the loader and a useful preview visible without pushing the editor or transcript.
TruncatedText; keep the 4,000‑char tail bound.statusContainer; preserve the active loader and prevent history/composer shifts.Written for commit 21e1356. Summary will update on new commits.