Fix dependency version range - #111
Merged
Merged
Conversation
Fixed version range is unnecessary in this case and will cause troubles to consumers.
Collaborator
|
I can't agree here :/ We cannot guarantee this package will be compatible with every future version of its dependency. We can put trust on this but then things are "released" without testing and are out of the control. However, I think, we can use |
Contributor
Author
|
Version ranges is a topic on it's own, but fixed versions are almost never good in library package. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed version range is unnecessary in this case and will cause troubles to consumers.