LIN-4849 Remove conflict overwrite for KTs#42
Merged
Conversation
Mid-air collisions let kiosk techs (FSR) clobber concurrent dispatch edits by choosing "overwrite" on the conflict dialog, wiping parts orders. Add an :overwrite_conflicting_updates permission (granted to every role but FSR via the LIN-4849 evolve); hide the overwrite radio and skip the lock_version drop when the user lacks it, so the save re-raises the conflict instead of clobbering. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The issue-form JS reads Parts Status via findInput(); a read-only field renders without an input, so findInput() returns empty and .val() is undefined. Guard removeSendParts() and the submit handler on the input being present, so a read-only Parts Status skips the automation instead of acting as if empty (which would strip "Send Parts" from the status list). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
frillweeman
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:overwrite_conflicting_updatespermission. The conflict dialog's "overwrite" radio and the controller'slock_versiondrop are gated on it, so KTs (FSR — which lacks the permission) can no longer clobber a concurrent update on save.k2/shared/schema).Checklist