Skip to content

Prepare release - #69

Merged
talex5 merged 1 commit into
mirage:masterfrom
talex5:release
Aug 7, 2026
Merged

Prepare release#69
talex5 merged 1 commit into
mirage:masterfrom
talex5:release

Conversation

@talex5

@talex5 talex5 commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread CHANGES.md Outdated

Core/Lwt split:

- Add a new `prometheus-lwt` metrics package (@avsm @mtelvers @talex5 #66 #60 #65)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A review is also a work from my side, but I will not block this release...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I've added you (and also removed #60 and #65 from here as they're not actually included in this release).

@talex5

talex5 commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

I tested the new release on ocluster (https://github.com/talex5/ocluster/pull/new/prometheus-1.4), which turned out to be an interesting case!

  • ocluster-scheduler does its own metrics reporting rather than using Prometheus_unix.serve because it has multiple metrics endpoints (it re-exports per-worker metrics).
  • ocluster-worker reports metrics over capnp-rpc, not HTTP.
  • However, both still runs OK with 1.4 using the old deprecated functions, because they use Prometheus_unix.Logging to configure logging and that initialises the time function.
  • But a unit-test failed because it uses collect to check the metrics without setting a time function.

That doesn't seem like it needs to be a blocker though.

@talex5
talex5 merged commit e480680 into mirage:master Aug 7, 2026
1 check was pending
@talex5
talex5 deleted the release branch August 7, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants