Use mtime to measure times - #70
Open
talex5 wants to merge 1 commit into
Open
Conversation
This has several advantages: - It isn't affected by changes to the system clock. - It has better precision. - Anything using `Prometheus_app` will have working time (without having to remember to call `Prometheus.init` itself).
Contributor
Author
|
With this change, OCurrent and OCluster tests pass without needing any changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using mtime has several advantages:
Prometheus_appwill have working time (without having to remember to callPrometheus.inititself).Since
Prometheus_appincludes the text formatter, this should be most things.(When releasing v1.4, it turned out that using
Prometheus_appwithoutPrometheus_unixwas more common than I expected in #68)