Feature/query #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omgoo
approved these changes
Apr 29, 2021
Leeeebs
approved these changes
Apr 29, 2021
mdncs
approved these changes
Apr 29, 2021
pywb/apps/rewriterapp.py
Outdated
Comment on lines
826
to
835
| # fields = t.split(b' ') | ||
| # if len(fields) > 14: | ||
| # fields = fields[:-2] | ||
| # for i in CDXObject().CDX_FORMATS: | ||
| # if len(i) == len(fields): | ||
| # cdxformat = i | ||
| # | ||
| # if not cdxformat: | ||
| # msg = f'unknown {len(fields)}-field cdx format: {fields}' | ||
| # raise CDXException(msg) |
There was a problem hiding this comment.
Do we still need this? Generally we'd remove code that's commented out.
Comment on lines
+272
to
+277
| choices = { | ||
| '1': 'Jan', '2': 'Feb', '3': 'Mar', | ||
| '4': 'Apr', '5': 'May', '6': 'Jun', | ||
| '7': 'Jul', '8': 'Aug', '9': 'Sep', | ||
| '10': 'Oct', '11': 'Nov', '12': 'Dec' | ||
| } |
There was a problem hiding this comment.
No biggie but we could generate these dynamically and avoid hard-coded values:
>>> import datetime
>>>
>>> choices = {i: datetime.date(2008, i, 1).strftime('%b') for i in range(1, 13)}
>>> choices
{1: 'Jan', 2: 'Feb', 3: 'Mar', 4: 'Apr', 5: 'May', 6: 'Jun', 7: 'Jul', 8: 'Aug', 9: 'Sep', 10: 'Oct', 11: 'Nov', 12: 'Dec'}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.