Adoption fixes#1
Merged
misconfigurations merged 5 commits intomisconfigurations:masterfrom May 7, 2026
Merged
Conversation
This is since the plugin adopter wants to support only Python >= 3.7 (see pyproject.toml). This should greatly reduce the code surface, making everything easier to maintain.
The adopter forgot to do it
E.g., unused vars, type comparisons using equals, etc
Owner
|
Thank you for this for these fixes. I'm merging this PR now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR takes the opportunity of the ongoing adoption to modernize this plugin codebase.
Since the new
pyproject.tomlsets Python 3.7 as the minimum supported version, there is no longer any reason to keep all the legacy Python 2 branchings in the code.The
get_update_informationfunction is also fixed to point to this repository.Finally, there are some minor refactors with no functional impact, such as converting comparisons that used
==instead ofis, and removing dead code.Please note that all of this, while it doesn't seem like it could reasonably be wrong code-wise, and most of the changes I've made are semantically equivalent, hasn't been tested, so it's up to you.