Skip to content

docs: document mobileAuthHandoffs cleanup window behavior (#530)#561

Merged
joryirving merged 3 commits into
misospace:mainfrom
itsmiso-ai:saffron/fix-issue-530-mobile-auth-cleanup-doc
Jun 11, 2026
Merged

docs: document mobileAuthHandoffs cleanup window behavior (#530)#561
joryirving merged 3 commits into
misospace:mainfrom
itsmiso-ai:saffron/fix-issue-530-mobile-auth-cleanup-doc

Conversation

@itsmiso-ai

Copy link
Copy Markdown
Contributor

Fixes #530

Add documentation comment above the setInterval cleanup block to explain the 60-second cleanup granularity and why it's acceptable per audit findings.

The comment clarifies that:

  • Expired tokens may linger for up to 60s after expiration in low-traffic deployments
  • consumeMobileAuthToken() rejects expired tokens on access
  • The unref() call ensures the interval won't prevent process exit

Add documentation comment above the setInterval cleanup block to explain
the 60-second cleanup granularity and why it's acceptable per audit findings.

Fixes #530
@itsmiso-ai
itsmiso-ai requested a review from joryirving as a code owner June 10, 2026 07:28
@joryirving
joryirving merged commit 6894380 into misospace:main Jun 11, 2026
7 of 9 checks passed
itsmiso-ai added a commit to itsmiso-ai/dispatch-workflow that referenced this pull request Jun 11, 2026
Worker-created branches must be pushed directly to misospace/* origin.
No forks exist for misospace/* repos. Cross-repo/fork PRs break the AI
PR review CI because GitHub does not forward secrets (e.g. ACTIONS_APP_ID,
ACTIONS_APP_PRIVATE_KEY) to fork PR runs.

The review job will fail with: 'Error: The client-id (or deprecated
app-id) input must be set to a non-empty string.'

After creating a PR, verify with:
  gh pr view --json isCrossRepository
If true, the push is wrong. Fix it before reporting Done.

Triggered by misospace/miso-chat#561 which was the only cross-repo PR
out of 20+ itsmiso-ai PRs on misospace/miso-chat.

Co-authored-by: Saffron Worker <saffron@kubetix.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

P2 ops: add test or documentation for mobileAuthHandoffs cleanup behavior

2 participants