ci: use BOT_CLIENT_ID secret for the app token

[joryirving]

Completes the BOT_APP_ID → BOT_CLIENT_ID migration started in the v1.2.2 upgrade PR — this was the remaining reference outside the AI-review workflow.

🤖 Generated with Claude Code

[its-saffron]

AI Automated Review

Full PR review.

Analysis engine: review@https://litellm.jory.dev/v1 (openai)

Recommendation

Approved. This PR completes a migration of secret references to ensure consistency across the repository's CI/CD workflows.

Change-by-change findings

• .github/workflows/manual-release.yml: Updated the client-id parameter for the actions/create-github-app-token step to use BOT_CLIENT_ID instead of the deprecated BOT_APP_ID. This aligns the manual release workflow with the updated secret naming convention used elsewhere in the repository.

Standards Compliance

• Security: The change correctly transitions to using a more specific secret (BOT_CLIENT_ID), which is a best practice for least-privilege access and clarity in secret management.
• Consistency: This change fulfills the migration started in previous PRs (as noted in the PR description) to ensure all references to the bot's identity are consistent.

Linked Issue Fit

• The PR body indicates this is the final step in a migration started in the v1.2.2 upgrade PR. It successfully addresses the remaining reference to BOT_APP_ID outside of the AI-review workflow.

Unknowns or Needs Verification

• None. The change is a straightforward secret name update in a GitHub Actions workflow file.