fix(ci): correct invalid action SHAs in android-release workflow#613
Merged
Conversation
The setup-node SHA had a typo (9c2e8 vs 9c7362e8) and setup-java had an outdated/invalid SHA. Both caused the Android build to fail at action resolution, preventing APK and OTA bundle uploads for releases 0.4.14 and 0.4.15. Fixes the broken mobile release pipeline so APKs and OTA bundles are published again.
Contributor
There was a problem hiding this comment.
AI Automated Review
Full PR review.
Analysis engine: MiniMax-M2.7@https://litellm.jory.dev/v1 (anthropic) — escalated (fast_low_confidence)
Review: Approve
Recommendation
Approve. This PR correctly fixes two invalid action SHAs in the Android release workflow. The fix is well-documented, the new SHAs are verified against the rest of the repository's workflows, and the change is minimal and targeted.
Change-by-Change Findings
.github/workflows/android-release.yml
- Line 36 (
Setup Node.js): Old SHA48b55a011bda9f5d6aeb4c2d9c2e8dae4041ehas a clear typo (d9c2e8→d9c7362). New SHA48b55a011bda9f5d6aeb4c2d9c7362e8dae4041eis confirmed valid and matches every other workflow in the repository (dependency-audit.yaml,lint.yaml,manual-release.yml,release.yaml,tests.yaml). ✅ - Line 41 (
Setup Java): Old SHAbe666c2fcd27ec809703dec502508b2fdc7f6654replaced withad2b38190b15e4d6bdf0c97fb4fca8412226d287(v5.3.0). The new SHA and version tag are consistent. ✅ - Version comments updated from generic (
v6,v5) to precise (v6.4.0,v5.3.0), which improves clarity. ✅
Sources
- PR diff (verified SHAs, line numbers, version tags)
- Repository Impact Scan —
48b55a011bda9f5d6aeb4c2d9c7362e8dae4041econfirmed across 6 other workflow files - Repository History — confirmed
48b55a0prefix used consistently for setup-node updates
Standards Compliance
- No repository standards violations (no AGENTS.md requirements apply to GitHub Action SHA management beyond correctness)
- SHA pin conventions match the rest of the repo's workflows
- Release process: this is a prerequisite fix so the Android release workflow can run at all; after merge, the v0.4.15 release can be re-triggered via
workflow_dispatchas documented
Linked Issue Fit
- No linked issues; PR body fully self-documents the problem, root cause, and verification approach
CI Check Results
lint,dockerfile-lint, andbuild(amd64) all passedtestfailure is unrelated to this PR (infrastructure/existing test issue, not caused by workflow file changes)build(arm64) still in progress — no signal to block on
Unknowns / Needs Verification
- None. Both new SHAs are cross-verified from other workflow files in the repo.
Findings
No findings to report. This is a clean, correct, low-risk fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Android build workflow (
android-release.yml) has two invalid action SHAs that cause it to fail immediately at action resolution:actions/setup-node— SHA48b55a011bda9f5d6aeb4c2d9c2e8dae4041ehas a typo. The correct SHA is48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e(v6.4.0), matching all other workflows.actions/setup-java— SHAbe666c2fcd27ec809703dec502508b2fdc7f6654is no longer valid. The correct SHA isad2b38190b15e4d6bdf0c97fb4fca8412226d287(v5.3.0).This broke the Android release builds for v0.4.14 and v0.4.15. The last successful Android build was v0.4.13. The mobile app never received the CSP fix (#604) or missing JS files (#605), so it's still stuck on 'Connecting to OpenClaw Gateway'.
Fix
Update both SHAs to the correct values matching the rest of the repo's workflows.
Verification