Remove the popup-states flowchart diagram and its generator - #760
Conversation
The five-state decision the popup makes is already specified in prose in requirements.md §12–§16 and in popup.js's chooseContent comment, so the hand-authored PNG was a second, drift-prone copy of the same information. Deletes dev/requirements/shared/popup-states-flowchart.png and the gen-states-flowchart.js that existed only to regenerate it, plus the four references (requirements.md embed, requirements/README.md tree entry, fileDescriptions.md row, popup.js comment pointer). @resvg/resvg-js stays — the UI snapshot renderer still uses it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VNBDf82WMVkNPvahd4b9mg
|
Conversation extract — source dialogue. Rule added: "No pack prose and no owner preferences in context means the SessionStart hook never fired — re-run it before acting on owner shorthand" (gcec Owner: Eliminate popup-states-flowchart.png and references. Assistant: I'll find the file and its references. What was removed:
Want me to watch the PR for CI failures and review comments? Owner: lgtm Assistant: Thanks. PR #760 is open and ready for review — say the word if you'd like me to merge it, or subscribe to watch CI and review comments. Owner: did you load my preferences? Assistant: No — they weren't. My session context this turn had only Generated by Claude Code |
|
Rule added — "Cap and qualify every GitHub MCP list/search call" in The exchange: after the flowchart removal landed in PR #760, the session went to confirm CI before merging. Why the rule follows: it is the same failure mode the tracker-issue lookups hit in the #734 and #753 sessions — an unbounded GitHub MCP list/search whose payload dwarfs the one field actually wanted. The rule now says to qualify the query and cap the page size on every such call, and to prefer Generated by Claude Code |
One keeper from the four queued conversation logs: cap and qualify GitHub MCP list/search calls. Three tracker-issue lookups via `search_issues` with a bare title string returned 185-211 KB and hard-failed the tool-result cap (logs for #734 twice, #753), as did an unpaged `actions_list` at 155 KB (#760) - each forcing a 2-3 call grep/sed dig through the saved result file. Landed as prose in the gcec pack (not mechanically checkable: it is runtime tool usage, not repo content), plus its row in the pack README's rules table. The other friction in the batch was already covered or out of policy: the `git checkout <branch> -- <paths>` footgun is already RULES.md's first working rule (captured from that same #734 session); the unmounted `merge-to-main` skill and the missed SessionStart preference injection are Claudinite loading mechanics, which the pack's capture policy keeps out. Refs #783 Co-authored-by: Claude <noreply@anthropic.com>
Removes
dev/requirements/shared/popup-states-flowchart.pngand every reference to it.The five-state decision the popup makes is already specified in prose in
requirements.md§12–§16 and inpopup.js'schooseContentcomment, so the hand-authored PNG was a second, drift-prone copy of the same information.Changes
dev/requirements/shared/popup-states-flowchart.png.dev/requirements/shared/gen-states-flowchart.js— it existed solely to regenerate that PNG.requirements.md§12 image embed, thedev/requirements/README.mdlayout-tree entry, thedev/procedures/fileDescriptions.mdrow for the generator, and the diagram pointer in theextension/events-popup/popup.jscomment (the §12–§16 spec pointer stays).@resvg/resvg-jsremains a dev dependency — the UI snapshot renderer (dev/requirements/shared/render/popup-renderer.js) still uses it.Verification
npm test— 517 tests, 0 failures, 8 skipped. A repo-wide grep forpopup-states-flowchartandgen-states-flowchartreturns nothing.Generated by Claude Code