Skip to content

Also publish the DMG when a Release is published from the UI - #13

Merged
missingbulb merged 1 commit into
mainfrom
claude/laugh-detection-logging-lq957s
Jul 12, 2026
Merged

Also publish the DMG when a Release is published from the UI#13
missingbulb merged 1 commit into
mainfrom
claude/laugh-detection-logging-lq957s

Conversation

@missingbulb

Copy link
Copy Markdown
Owner

Adds a release: published trigger to release-macos-dmg.yml so you can cut a release from the GitHub UI (handy on mobile) — creating the tag v0.2.0 there — and still have the workflow build the app and attach LaughCounter.dmg. The GitHub UI creates the tag but doesn't fire push: tags, which is why this trigger is needed.

The existing tag-push path is unchanged and won't double-build: a tag pushed via git has its Release created with GITHUB_TOKEN, which by design doesn't re-fire the release event.

Refs #11

🤖 Generated with Claude Code


Generated by Claude Code

Add a `release: published` trigger to release-macos-dmg.yml so a Release created
in the GitHub UI (which creates the tag but does not fire `push: tags`) still
builds the app and attaches LaughCounter.dmg. The tag-push path is unchanged and
won't double-build (its Release is created with GITHUB_TOKEN, which doesn't
re-fire the `release` event).

Refs #11

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ATTAHuLKSR8K7ZFawgbncJ
@missingbulb
missingbulb merged commit 6b5a6c5 into main Jul 12, 2026
1 check passed
missingbulb added a commit that referenced this pull request Jul 14, 2026
The two release-automation gotchas learned wiring release-macos-dmg.yml were
only recorded in commit messages (#13, #19) and the workflow YAML comments, so a
future session touching the release flow wouldn't be pointed at them. Re-home
them into a local instruction doc reachable from CLAUDE.md:

- A Claude Code web session's git proxy can't push v* tags, so a tag-triggered
  release never fires from a session — trigger on push-to-main instead (#18/#19).
- A UI-published Release doesn't emit push: tags — add release: published so a
  hand-published Release still builds/attaches the DMG (#11/#13).

Creates the dev/procedures/ instruction-doc scaffold (none existed) and imports
it from the root CLAUDE.md.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018DKJNecs661QFXT5YZEeTn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants