ci: run DMG workflow steps with pipefail - #27
Merged
Conversation
Set defaults.run.shell: bash in both DMG workflows so GitHub runs each step with 'bash -o pipefail'. Without it the implicit shell is 'bash -e' (no pipefail), so a failure in the left side of a pipe — e.g. the base64-decode of the signing cert or the keychain-list feeding sed in the cert-import step — would be masked and the step would still show green. Refs #26 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WVpWDYmMWjhHz48vdotPpP
This was referenced Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Follow-up to #4. Both DMG workflows have piped
run:steps (the signing-certbase64 --decode, andsecurity list-keychains … | sed …in the cert-import step). GitHub's implicit shell isbash -ewithoutpipefail, so a failure on the left side of a pipe would be masked and the step would still go green.Setting
defaults.run.shell: bashmakes GitHub run each step withbash -o pipefail, so those failures surface.Changes
.github/workflows/build-macos-dmg.yml— addshell: bashtodefaults.run..github/workflows/release-macos-dmg.yml— same.Refs #26
🤖 Generated with Claude Code
Generated by Claude Code