Skip to content

fix(gh): check-misskey-js-autogenが失敗する問題を修正 - #17809

Merged
syuilo merged 3 commits into
misskey-dev:developfrom
kakkokari-gtyih:fix-workflow-safeguard-checkout-v7
Jul 27, 2026
Merged

fix(gh): check-misskey-js-autogenが失敗する問題を修正#17809
syuilo merged 3 commits into
misskey-dev:developfrom
kakkokari-gtyih:fix-workflow-safeguard-checkout-v7

Conversation

@kakkokari-gtyih

@kakkokari-gtyih kakkokari-gtyih commented Jul 27, 2026

Copy link
Copy Markdown
Member

What

  • check-misskey-js-autogenが失敗するのを修正
  • より安全な方式(他のdiagnostics系でも使用されている方式)に変更

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Misskey JS自動生成チェックをpull_request実行へ変更し、結果をアーティファクトとして保存します。別のworkflow_runワークフローが結果を検証し、差分の有無に応じてPRコメントを投稿または削除します。

Changes

Misskey JS自動生成結果フロー

Layer / File(s) Summary
チェック結果の生成と保存
.github/workflows/check-misskey-js-autogen.yml
トリガーをpull_requestへ変更し、後段ジョブを更新しました。PR番号と差分有無をmisskey-js-autogen-resultアーティファクトとして保存し、直接のコメント送信を削除しています。
アーティファクトによるPRコメント管理
.github/workflows/check-misskey-js-autogen.comment.yml
workflow_run完了時に結果を取得・検証し、差分がある場合は固定タグのコメントを投稿し、ない場合は該当コメントを削除します。

Estimated code review effort: 3 (Moderate) | ~20 minutes

Suggested labels: size:XS

Poem

自動生成の結果を包み
アーティファクトが橋を渡り
コメントがそっと現れます
差分がなければ消えゆき
ワークフローは今日も進みます

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning What はありますが、Why が空欄で、変更理由と課題の説明が不足しています。 Why に失敗原因と、この方式へ変える理由を1~2文で追記し、必要なら Additional info も補完してください。
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed 変更内容の中心である check-misskey-js-autogen の失敗修正を、簡潔に示せています。
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@kakkokari-gtyih
kakkokari-gtyih marked this pull request as ready for review July 27, 2026 06:50
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 27, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/check-misskey-js-autogen.yml:
- Around line 25-26: Do not enable allow-unsafe-pr-checkout for the
pull_request_target job that runs pnpm install, build, and generate-api-json.
Move these fork-controlled generation commands to a pull_request workflow, or
separate them into an untrusted job while keeping only trusted code in
pull_request_target.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 80290dd2-230c-4481-8432-79c756a0c51a

📥 Commits

Reviewing files that changed from the base of the PR and between f697933 and 14cd489.

📒 Files selected for processing (1)
  • .github/workflows/check-misskey-js-autogen.yml

Comment thread .github/workflows/check-misskey-js-autogen.yml Outdated
@syuilo
syuilo merged commit cb58ff3 into misskey-dev:develop Jul 27, 2026
6 checks passed
@syuilo

syuilo commented Jul 27, 2026

Copy link
Copy Markdown
Member

🙏🏻

@github-project-automation github-project-automation Bot moved this from Todo to Done in [実験中] 管理用 Jul 27, 2026
@kakkokari-gtyih
kakkokari-gtyih deleted the fix-workflow-safeguard-checkout-v7 branch July 27, 2026 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Development

Successfully merging this pull request may close these issues.

2 participants