This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Add support for parsing json.Number to uint64#261
Merged
mitchellh merged 2 commits intoDec 1, 2021
Conversation
Owner
|
There are a couple test failures that look trivial to fix. If you can fix those up I'd be happy to merge, your impl looks good to me. |
Author
|
Sure, I've submitted the fix. Please take a look. |
Owner
|
Thank you! I'll cut a new tag soon, maybe tmrw morning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
json.Numbercan represent a number in range [2^63 + 1, 2^64), which is suitable for an uint64 value but overflow for an int64 value. When parsingjson.Numberto uint64, current implementation can't handle number in this range.Since
json.Numberis basically string, we can parse string to uint64 directly. I've also add some unit tests.