feat: add Microsoft Edge support to the Browser addon - #8408
Open
eliahu-frusin wants to merge 1 commit into
Open
feat: add Microsoft Edge support to the Browser addon#8408eliahu-frusin wants to merge 1 commit into
eliahu-frusin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
The Browser addon (
mitmproxy/addons/browser.py) supports launching anisolated, proxy-configured instance of Chrome or Firefox via
browser.start, but had no equivalent for Microsoft Edge. Users withoutChrome or Firefox installed -- e.g. Windows users, where Edge is always
pre-installed -- had no working option.
Proposed in #8407 and confirmed welcome by maintainers before implementing.
Changes
mitmproxy/addons/browser.py: addedlaunch_edge(), following the exactsame structure as
launch_chrome()-- executable search paths acrossmacOS/Windows/Linux, a Flatpak fallback (
com.microsoft.Edge), and thesame isolated
--user-data-dir/--proxy-serverlaunch flags (Edge isChromium-based, so the same flags apply). Wired into the
browser.startcommand dispatcher alongside the existing
chrome/firefoxbranches.test/mitmproxy/addons/test_browser.py: addedtest_browser_start_edgeand
test_browser_start_edge_not_found, mirroring the existing Firefoxtest pattern.
Closes #8407
Checklist