Skip to content

contrast fix for banner on channel pages #1058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

contrast fix for banner on channel pages #1058

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e9b0e8a
reversing background images horizontally
shanbady Jun 11, 2024
228d9a4
adding initial 30% dark overlay component
shanbady Jun 11, 2024
0528f1f
inheriting from common component
shanbady Jun 11, 2024
5bf8dac
switching to modern color notation
shanbady Jun 11, 2024
4850dce
fixing color notation
shanbady Jun 11, 2024
b1e3d00
fixing color notation
shanbady Jun 11, 2024
508ba52
fixing color notation
shanbady Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified frontends/mit-open/public/images/unit_banners/see.jpg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified frontends/mit-open/public/images/unit_banners/xpro.jpg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
13 changes: 9 additions & 4 deletions frontends/ol-components/src/components/BannerPage/BannerPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,20 @@ interface ImgProps {
alt?: string
}

/**
* Prefer direct use of `BannerPage` component.
*/
const BannerContainer = styled.div`
const BannerOverlayGradient = styled.div`
position: absolute;
top: 0;
left: 0;
width: 100%;
height: 100%;
z-index: -1;
background-color: rgba(0 0 0 / 30%);
`
/**
* Prefer direct use of `BannerPage` component.
*/
const BannerContainer = styled(BannerOverlayGradient)`
z-index: -2;
`

const imageStylesheet = `
Expand Down Expand Up @@ -109,6 +113,7 @@ const BannerPage: React.FC<BannerPageProps> = ({
return (
<BannerPageWrapper className={className}>
<BannerPageHeaderFlex className={bannerContainerClass}>
<BannerOverlayGradient></BannerOverlayGradient>
<BannerContainer>
{!omitBackground && <BannerImage src={src} alt={alt} />}
</BannerContainer>
Expand Down