contrast fix for banner on channel pages #1058
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanbady
added
Work in Progress
and removed
Needs Review
Contributor
Author
|
Given that we moved a lot of things around (offerors-> units) and there is a much larger set of UI changes in progress i think it makes sense to fold the changes here into my other PR #1063 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes #1045
Description (What does it do?)
Adds a 30% opacity overlay to the channel pages so the text is more visible
This PR also includes changes to some banner backgrounds that are flipped horizontally to match the figma.
Screenshots (if appropriate):
Before:
After
How can this be tested?