Skip to content

Remap topic icons according to what's in the topics listing #1322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Remap topic icons according to what's in the topics listing #1322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58fc9eb
Remap topic icons according to what's in the topics listing
jkachel Jul 26, 2024
d493834
fixing off-by-one error in test
jkachel Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontends/mit-open/src/components/RootTopicIcon/RootTopicIcon.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ describe("TopicIcon", () => {
* at least make sure we have an icon for each of them.
*/
test.each(rootTopicNames)("Root topics all have an icon", (name) => {
expect(rootTopicNames.length).toBe(11)
expect(rootTopicNames.length).toBe(12)
render(<RootTopicIcon name={name} />)
const svg = document.querySelector("svg")
expect(svg).toBeVisible()
Expand Down
17 changes: 9 additions & 8 deletions frontends/mit-open/src/components/RootTopicIcon/RootTopicIcon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,17 +15,18 @@ import React from "react"

/* TODO Using any icons until we have a solution for specifying them */
export const ICON_MAP = {
Business: RiBriefcase3Line,
Energy: RiLightbulbFlashLine,
Engineering: RiRobot2Line,
"Fine Arts": RiPaletteLine,
"Health and Medicine": RiStethoscopeLine,
"Business & Management": RiBriefcase3Line,
"Energy, Climate & Sustainability": RiLightbulbFlashLine,
"Data Science, Analytics & Computer Technology": RiRobot2Line,
"Art, Design & Architecture": RiPaletteLine,
"Health & Medicine": RiStethoscopeLine,
Humanities: RiQuillPenLine,
Mathematics: RiInfinityLine,
Science: RiTestTubeLine,
"Social Science": RiUserSearchLine,
"Science & Math": RiTestTubeLine,
"Social Sciences": RiUserSearchLine,
Society: RiEarthLine,
"Teaching and Education": RiShakeHandsLine,
"Education & Teaching": RiShakeHandsLine,
Engineering: RiRobot2Line,
}

type RootTopicIconProps = { name: string }
Expand Down