Skip to content

Codespace opensearch service fix #1582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 19, 2024
Merged

Codespace opensearch service fix #1582

merged 2 commits into from
Sep 19, 2024

Conversation

@shanbady
Copy link
Contributor

@shanbady shanbady commented Sep 18, 2024 •
edited
Loading

Description (What does it do?)

Fixes an issue where the opensearch service is not started when creating a codespace due to a descrepency with copose versions and how we now inherit compose configurations

How can this be tested?

  1. No need to check out any code! create a codespace directly off of this PR - You can click this in the bottom right to follow the build progress:
Screenshot 2024-09-18 at 2 59 34 PM
  1. Let it finish initializing (A few minutes after you see 3 ports show up in the ports tab - you will want the initialization script to complete as well - a blue "Finished configuring codespace." should show up at the bottom of the terminal tab)
  2. In the ports tab - set port 8063 to "public"
  3. Visit the running frontend at the 8062 address - You should be able to go to the search page and see some results display

@shanbady shanbady added the Needs Review An open Pull Request that is ready for review label Sep 18, 2024
@shanbady shanbady marked this pull request as ready for review September 18, 2024 19:06
rhysyngsun
rhysyngsun approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@rhysyngsun rhysyngsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shanbady shanbady merged commit d7209f6 into main Sep 19, 2024
@odlbot odlbot mentioned this pull request Sep 19, 2024
Merged
5 tasks
jonkafton added a commit that referenced this pull request Sep 25, 2024
@jonkafton @shanbady
@odlbot @mbertrand @abeglova
Merge latest from main (#1602)
7d2de23 
* Codespace opensearch service fix (#1582)

* testing codespace fix

* testing fix

* Release 0.19.2

* Fix extract_openedx_data and backpopulate_mit_edx_data commands to work with course/program datafiles (#1587)

* follow/unfollow popover (#1589)

* adding success variant

* adding working version

* adding working version

* fixing text and adding margin to buttons

* lint fixes

* lint fix

* fixing test cases

* closing popup before posting data

* removing redundancy

* removing redundancy

* removing empty test

* updating styles

* updating styles

* changes to match design

* changes to match design

* Make search mode defaults settable env variables (#1590)

* Release date for 0.19.2

* Release 0.19.3

* Release date for 0.19.3

* Pace and format fields for learning resources (#1588)

* Migrate search settings #5527

---------

Co-authored-by: Shankar Ambady <shanbady@gmail.com>
Co-authored-by: Doof <mitx-devops@mit.edu>
Co-authored-by: Matt Bertrand <mrbertrand@gmail.com>
Co-authored-by: Anastasia Beglova <abeglova@mit.edu>
@rhysyngsun rhysyngsun deleted the codespace-opensearch-fix branch February 7, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhysyngsun rhysyngsun rhysyngsun approved these changes

Assignees

No one assigned

Labels

Needs Review An open Pull Request that is ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shanbady @rhysyngsun