Skip to content

Conversation

@shanbady
Copy link
Contributor

@shanbady shanbady commented Sep 20, 2024

What are the relevant tickets?

Closes https://github.com/mitodl/hq/issues/5385

Description (What does it do?)

This PR introduces a follow action popover when clicking 'follow' on channel pages as described in https://github.com/mitodl/hq/issues/5385

Screenshots (if appropriate):

Screenshot 2024-09-23 at 11 34 08 AM Screenshot 2024-09-23 at 11 34 20 AM

How can this be tested?

  1. checkout this branch (or start a codespace)
  2. visit a unit, department or topic channel page and click follow
  3. as an anonymous user you should see the signup action popover - logged in users will see a follow/unfollow or close action popover

@shanbady shanbady marked this pull request as ready for review September 20, 2024 19:38
@shanbady shanbady added Needs Review An open Pull Request that is ready for review and removed Work in Progress labels Sep 20, 2024
@abeglova abeglova self-assigned this Sep 23, 2024
Copy link
Contributor

@abeglova abeglova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shanbady shanbady merged commit c849ff9 into main Sep 23, 2024
@shanbady shanbady deleted the shanbady/follow-unfollow-popover branch September 23, 2024 15:47
@odlbot odlbot mentioned this pull request Sep 23, 2024
3 tasks
jonkafton added a commit that referenced this pull request Sep 25, 2024
* Codespace opensearch service fix (#1582)

* testing codespace fix

* testing fix

* Release 0.19.2

* Fix extract_openedx_data and backpopulate_mit_edx_data commands to work with course/program datafiles (#1587)

* follow/unfollow popover (#1589)

* adding success variant

* adding working version

* adding working version

* fixing text and adding margin to buttons

* lint fixes

* lint fix

* fixing test cases

* closing popup before posting data

* removing redundancy

* removing redundancy

* removing empty test

* updating styles

* updating styles

* changes to match design

* changes to match design

* Make search mode defaults settable env variables (#1590)

* Release date for 0.19.2

* Release 0.19.3

* Release date for 0.19.3

* Pace and format fields for learning resources (#1588)

* Migrate search settings #5527

---------

Co-authored-by: Shankar Ambady <shanbady@gmail.com>
Co-authored-by: Doof <mitx-devops@mit.edu>
Co-authored-by: Matt Bertrand <mrbertrand@gmail.com>
Co-authored-by: Anastasia Beglova <abeglova@mit.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review An open Pull Request that is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants