-
Notifications
You must be signed in to change notification settings - Fork 3
follow/unfollow popover #1589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
follow/unfollow popover #1589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeglova
approved these changes
Sep 23, 2024
Contributor
abeglova
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jonkafton
added a commit
that referenced
this pull request
Sep 25, 2024
* Codespace opensearch service fix (#1582) * testing codespace fix * testing fix * Release 0.19.2 * Fix extract_openedx_data and backpopulate_mit_edx_data commands to work with course/program datafiles (#1587) * follow/unfollow popover (#1589) * adding success variant * adding working version * adding working version * fixing text and adding margin to buttons * lint fixes * lint fix * fixing test cases * closing popup before posting data * removing redundancy * removing redundancy * removing empty test * updating styles * updating styles * changes to match design * changes to match design * Make search mode defaults settable env variables (#1590) * Release date for 0.19.2 * Release 0.19.3 * Release date for 0.19.3 * Pace and format fields for learning resources (#1588) * Migrate search settings #5527 --------- Co-authored-by: Shankar Ambady <shanbady@gmail.com> Co-authored-by: Doof <mitx-devops@mit.edu> Co-authored-by: Matt Bertrand <mrbertrand@gmail.com> Co-authored-by: Anastasia Beglova <abeglova@mit.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/5385
Description (What does it do?)
This PR introduces a follow action popover when clicking 'follow' on channel pages as described in https://github.com/mitodl/hq/issues/5385
Screenshots (if appropriate):
How can this be tested?