Release 0.64.1#3233
Conversation
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* remove default slide transition from dialogs * skip dialog transition during tests
podcast detail page --------- Co-authored-by: Ahtesham Quraish <ahtesham.quraish@192.168.10.19>
…3225) * feat: track Stay Updated button click with PostHog cta_clicked event --------- Co-authored-by: Ahtesham Quraish <ahtesham.quraish@192.168.10.19>
OpenAPI ChangesNo changes detected Unexpected changes? Ensure your branch is up-to-date with |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| infiniteItems: (id: number, params: Omit<ItemsListRequest, "offset">) => | ||
| infiniteQueryOptions({ | ||
| queryKey: learningResourceKeys.infiniteItems( | ||
| id, | ||
| params as ItemsListRequest, | ||
| ), | ||
| queryFn: async ({ pageParam }) => { | ||
| // We need to investigate why pageParam is always null and that make |
There was a problem hiding this comment.
Bug: The infinite query for podcast episodes is broken because pageParam is always null, causing only the first page of results to be fetched repeatedly.
Severity: HIGH
Suggested Fix
Investigate why pageParam is always null in the infiniteItems query. The getNextPageParam function within the useInfiniteQuery options should be corrected to properly extract the URL for the next page from the API response's next field. Ensure this value is returned so subsequent fetches can use it.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: frontends/api/src/hooks/learningResources/queries.ts#L143-L150
Potential issue: The infinite query for podcast episodes is not working correctly due to
an issue where the `pageParam` is always `null`. A developer comment in the code
confirms this behavior, which prevents the logic for fetching subsequent pages from
being executed. As a result, any action intended to load more items, such as a user
clicking a "Load more episodes" button that calls `fetchNextPage()`, will only re-fetch
the first page of results. This effectively breaks the pagination functionality for the
podcast episode list.
Did we get this right? 👍 / 👎 to inform future reviews.
| {subscribeUrl && ( | ||
| <StyledButton | ||
| href={subscribeUrl} | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| variant="primary" | ||
| startIcon={<RiPlayFill />} | ||
| > | ||
| Play Latest Episode | ||
| </StyledButton> | ||
| )} |
There was a problem hiding this comment.
Bug: The 'Play Latest Episode' button incorrectly navigates to an external subscription URL (subscribeUrl) instead of playing the episode in the inline player.
Severity: MEDIUM
Suggested Fix
Modify the 'Play Latest Episode' button to trigger an onClick handler, such as handlePlayClick, similar to other episode play buttons. This handler should find the latest episode, retrieve its audio URL, and pass it to the inline PodcastPlayer component to initiate playback. The href attribute should be removed.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: frontends/main/src/app-pages/PodcastPage/PodcastDetailPage.tsx#L498-L508
Potential issue: The 'Play Latest Episode' button on the podcast detail page does not
play the episode as its label and icon suggest. Instead of triggering the inline audio
player, the button's `href` is set to the podcast's `subscribeUrl` (either an Apple
Podcasts or RSS feed URL). Clicking the button navigates the user to this external
subscription link in a new tab, which is inconsistent with other play buttons on the
page and creates a confusing user experience.
Did we get this right? 👍 / 👎 to inform future reviews.
odlbot
added
waiting for checkboxes
all checkboxes checked
and removed
deploying to rc
waiting for checkboxes
labels
5 participants
Rachel Lougee
Ahtesham Quraish
Carey P Gumaer
Shankar Ambady
renovate[bot]