Skip to content

Conversation

@shanbady
Copy link
Contributor

What are the relevant tickets?

fixes test failure on main https://github.com/mitodl/mit-open/actions/runs/8332224748/job/22800891647?pr=630

Description (What does it do?)

sets external models setting to empty so test can create programcertficate objects

How can this be tested?

Tests should succeed

Additional Context

PR #617 locks down programcertficate tables as readonly. this PR was merged in after another PR that had tests for programcertificates

@shanbady shanbady added the Needs Review An open Pull Request that is ready for review label Mar 18, 2024
@codecov
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.83%. Comparing base (1b9c0ce) to head (7e598bf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #631       +/-   ##
===========================================
+ Coverage   50.34%   74.83%   +24.48%     
===========================================
  Files         102      246      +144     
  Lines        4626    11214     +6588     
  Branches      979     1948      +969     
===========================================
+ Hits         2329     8392     +6063     
- Misses       2242     2648      +406     
- Partials       55      174      +119     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shanbady shanbady marked this pull request as ready for review March 18, 2024 20:04
@ChristopherChudzicki ChristopherChudzicki added Waiting on author and removed Needs Review An open Pull Request that is ready for review labels Mar 18, 2024
@shanbady shanbady merged commit 4074b0e into main Mar 18, 2024
@shanbady shanbady deleted the shanbady/test-fix branch March 18, 2024 20:07
@odlbot odlbot mentioned this pull request Mar 18, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants