-
Notifications
You must be signed in to change notification settings - Fork 3
shanbady/separate database router and schema for program certificates #617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shanbady/separate database router and schema for program certificates #617
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #617 +/- ##
==========================================
+ Coverage 74.73% 74.75% +0.02%
==========================================
Files 245 246 +1
Lines 11170 11180 +10
Branches 1943 1944 +1
==========================================
+ Hits 8348 8358 +10
Misses 2648 2648
Partials 174 174 ☔ View full report in Codecov by Sentry. |
ChristopherChudzicki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
| class Meta: | ||
| managed = False | ||
| db_table = "external.programcertificate" | ||
| db_table = '"external"."programcertificate"' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fun.
What are the relevant tickets?
Closes #3771
Description (What does it do?)
The changes in this PR properly migrate the ProgramCertificate table to its own schema and also includes a database router that prevents writes from happening on tables in the external schema.
How can this be tested?
Additional Context
Our previous deploy of the programcertificate table ended up create a table in the public schema named "external.programcertificate".
The new migrations in this PR do the following to fix that: