chore(deps): make a duplicate version a decision somebody wrote down (R9) - #47
Merged
Merged
Conversation
…(R9) `multiple-versions` was "warn", and the tree was using the allowance: cargo-deny reports ten duplicated crates against this repository's own six targets. A warning is a line in a CI log nobody opens. The level is now "deny". Five `skip` entries and three `skip-tree` roots carry every duplicate the tree has today, each naming the edge that causes it rather than saying "upstream"; the three roots collapse the nine `windows-targets` and `windows_*` leaves, which are consequences of a `windows-sys` already listed and not decisions of their own. A duplicate that is not on the list is one somebody just introduced, and the build now stops before the merge. Nothing could be unified. `tokio`, `mio` and `socket2` are already on the same `windows-sys` this workspace takes directly. The one duplicate that is ours to remove sits under `keyring` 3.6.3, and `keyring` 4 rebuilt every backend into a crate of its own, which moves the direct edge ADR 0013 depends on — a migration, left as its own work. Two manifest comments disagreed with the tree and now do not. `getrandom` is not already present "through rustls and sqlx": both reach it only through `cc`'s jobserver at build time, while `rand` and `tempfile` are the run-time edges that make the claim true. And `rcgen`'s default `ring` backend is not one "rustls already puts in this tree" — rustls here runs on aws-lc-rs, so rcgen is what puts ring in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
multiple-versionswas"warn", and the tree was using the allowance: cargo-denyreports ten duplicated crates against this repository's own six targets. A warning
is a line in a CI log nobody opens.
The level is now
"deny". Fiveskipentries and threeskip-treeroots carry everyduplicate the tree has today, each naming the edge that causes it rather than saying
"upstream". The three roots collapse the nine
windows-targets/windows_*leaves,which are consequences of a
windows-sysalready listed and not decisions of theirown. A duplicate that is not on the list is one somebody just introduced, and the
build now stops before the merge.
The gate was watched failing before it was trusted: removing the
synentry makescargo deny check bansexit 2, restoring it exits 0.Nothing could be unified.
tokio,mioandsocket2are already on the samewindows-systhis workspace takes directly, so the finding's "follow upstream" had noupstream to follow. The one duplicate that is ours to remove sits under
keyring3.6.3, and
keyring4 rebuilt every backend into a crate of its own — which moves thedirect edge ADR 0013 depends on. That is a migration, left as its own work.
Two manifest comments disagreed with the tree and now do not.
getrandomis notalready present "through rustls and sqlx": both reach it only through
cc's jobserverat build time, while
randandtempfileare the run-time edges that make the claimtrue. And
rcgen's defaultringbackend is not one "rustls already puts in thistree" — rustls here runs on aws-lc-rs, so rcgen is what puts ring in: a new package,
not a new edge.
CI: all 10 jobs green on the first run.