Skip to content

Remove stale warning in node flags docs#47

Merged
efahk merged 2 commits into
mainfrom
fix_callout
Jul 22, 2026
Merged

Remove stale warning in node flags docs#47
efahk merged 2 commits into
mainfrom
fix_callout

Conversation

@efahk

@efahk efahk commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@efahk
efahk requested a review from a team as a code owner June 26, 2026 16:47
@efahk
efahk requested a review from myronkaifung June 26, 2026 16:47
@efahk
efahk enabled auto-merge (squash) June 26, 2026 16:59
@mintlify

mintlify Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
mixpanel-edb78807 🟢 Ready View Preview Jun 26, 2026, 5:17 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@greptile-apps

greptile-apps Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

This looks mergeable after clarifying the supported SDK version.

  • Older supported SDK versions may still evaluate advanced runtime rules incorrectly.
  • No security-sensitive behavior changes.

docs/tracking-methods/sdks/nodejs/nodejs-flags.mdx

Important Files Changed

Filename Overview
docs/tracking-methods/sdks/nodejs/nodejs-flags.mdx Removes the runtime-targeting limitation without stating which Node SDK versions support it.

Reviews (1): Last reviewed commit: "Merge branch 'main' into fix_callout" | Re-trigger Greptile

Support for runtime targeting has not yet been released. Thus runtime rules other than a single-condition, exact match key-value pair, will ALWAYS be evaluated to true.
</Warning>

<Warning>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Older SDKs Lose Runtime Warning

If full runtime targeting was released after the documented minimum Node SDK version, removing this warning also tells users of older supported versions that non-exact or multi-condition rules work. Those rules can instead evaluate as true and expose the wrong flag variant; qualify support with the SDK version that introduced it.

Context Used: Our developers like concise reviews. Avoid verbose... (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@efahk
efahk merged commit b43b1c7 into main Jul 22, 2026
6 checks passed
@efahk
efahk deleted the fix_callout branch July 22, 2026 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants