Build with gcc 14.2.0 causes array-bounds warning

[daschuer]

Bug Description

Happens during Flatpack build here:

https://github.com/flathub-infra/vorarbeiter/actions/runs/14741234429/job/41379560772

our own GitHub CI using gcc 13.3.0 is not affected

2025-04-29T21:26:40.1463840Z In file included from /usr/include/c++/14.2.0/bits/stl_pair.h:61,
2025-04-29T21:26:40.1465113Z                  from /usr/include/c++/14.2.0/utility:69,
2025-04-29T21:26:40.1466132Z                  from /usr/include/QtCore/qglobal.h:15,
2025-04-29T21:26:40.1466974Z                  from /usr/include/QtGui/qtguiglobal.h:7,
2025-04-29T21:26:40.1468440Z                  from /usr/include/QtWidgets/qtwidgetsglobal.h:7,
2025-04-29T21:26:40.1469132Z                  from /usr/include/QtWidgets/qstyleditemdelegate.h:7,
2025-04-29T21:26:40.1470635Z                  from /usr/include/QtWidgets/QStyledItemDelegate:1,
2025-04-29T21:26:40.1472134Z                  from /run/build/mixxx/src/controllers/delegates/controldelegate.h:3,
2025-04-29T21:26:40.1473074Z                  from /run/build/mixxx/src/controllers/delegates/controldelegate.cpp:1:
2025-04-29T21:26:40.1474697Z In function ‘constexpr _Tp std::__exchange(_Tp&, _Up&&) [with _Tp = char16_t*; _Up = std::nullptr_t]’,
2025-04-29T21:26:40.1476181Z     inlined from ‘constexpr _Tp std::exchange(_Tp&, _Up&&) [with _Tp = char16_t*; _Up = std::nullptr_t]’ at /usr/include/c++/14.2.0/utility:110:29,
2025-04-29T21:26:40.1494631Z     inlined from ‘QArrayDataPointer<T>::QArrayDataPointer(QArrayDataPointer<T>&&) [with T = char16_t]’ at /usr/include/QtCore/qarraydatapointer.h:79:28,
2025-04-29T21:26:40.1495991Z     inlined from ‘QString::QString(QString&&)’ at /usr/include/QtCore/qstring.h:182:12,
2025-04-29T21:26:40.1497025Z     inlined from ‘ConfigKey::ConfigKey(ConfigKey&&)’ at /run/build/mixxx/src/preferences/configobject.h:18:7,
2025-04-29T21:26:40.1498177Z     inlined from ‘T qvariant_cast(QVariant&&) [with T = ConfigKey]’ at /usr/include/QtCore/qvariant.h:774:67,
2025-04-29T21:26:40.1499235Z     inlined from ‘T QVariant::value() && [with T = ConfigKey]’ at /usr/include/QtCore/qvariant.h:529:47,
2025-04-29T21:26:40.1533084Z     inlined from ‘virtual void ControlDelegate::setEditorData(QWidget*, const QModelIndex&) const’ at /run/build/mixxx/src/controllers/delegates/controldelegate.cpp:71:63:
2025-04-29T21:26:40.1534790Z /usr/include/c++/14.2.0/bits/move.h:176:11: warning: array subscript 4 is outside array bounds of ‘QVariant [1]’ [-Warray-bounds=]
2025-04-29T21:26:40.1535624Z   176 |       _Tp __old_val = std::move(__obj);
2025-04-29T21:26:40.1536001Z       |           ^~~~~~~~~
2025-04-29T21:26:40.1537327Z /run/build/mixxx/src/controllers/delegates/controldelegate.cpp: In member function ‘virtual void ControlDelegate::setEditorData(QWidget*, const QModelIndex&) const’:
2025-04-29T21:26:40.1539097Z /run/build/mixxx/src/controllers/delegates/controldelegate.cpp:71:31: note: at offset 32 into object ‘<anonymous>’ of size 32
2025-04-29T21:26:40.1540233Z    71 |     ConfigKey key = index.data(Qt::EditRole).value<ConfigKey>();
2025-04-29T21:26:40.1540737Z       |                     ~~~~~~~~~~^~~~~~~~~~~~~~
2025-04-29T21:26:40.1541539Z In function ‘constexpr _Tp std::__exchange(_Tp&, _Up&&) [with _Tp = char16_t*; _Up = std::nullptr_t]’,
2025-04-29T21:26:40.1542790Z     inlined from ‘constexpr _Tp std::exchange(_Tp&, _Up&&) [with _Tp = char16_t*; _Up = std::nullptr_t]’ at /usr/include/c++/14.2.0/utility:110:29,
2025-04-29T21:26:40.1544317Z     inlined from ‘QArrayDataPointer<T>::QArrayDataPointer(QArrayDataPointer<T>&&) [with T = char16_t]’ at /usr/include/QtCore/qarraydatapointer.h:79:28,
2025-04-29T21:26:40.1545573Z     inlined from ‘QString::QString(QString&&)’ at /usr/include/QtCore/qstring.h:182:12,
2025-04-29T21:26:40.1546627Z     inlined from ‘ConfigKey::ConfigKey(ConfigKey&&)’ at /run/build/mixxx/src/preferences/configobject.h:18:7,
2025-04-29T21:26:40.1547766Z     inlined from ‘T qvariant_cast(QVariant&&) [with T = ConfigKey]’ at /usr/include/QtCore/qvariant.h:774:67,
2025-04-29T21:26:40.1548845Z     inlined from ‘T QVariant::value() && [with T = ConfigKey]’ at /usr/include/QtCore/qvariant.h:529:47,
2025-04-29T21:26:40.1553415Z     inlined from ‘virtual void ControlDelegate::setEditorData(QWidget*, const QModelIndex&) const’ at /run/build/mixxx/src/controllers/delegates/controldelegate.cpp:71:63:
2025-04-29T21:26:40.1555221Z /usr/include/c++/14.2.0/bits/move.h:177:13: warning: array subscript 4 is outside array bounds of ‘QVariant [1]’ [-Warray-bounds=]
2025-04-29T21:26:40.1556125Z   177 |       __obj = std::forward<_Up>(__new_val);
2025-04-29T21:26:40.1556561Z       |       ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2025-04-29T21:26:40.1558084Z /run/build/mixxx/src/controllers/delegates/controldelegate.cpp: In member function ‘virtual void ControlDelegate::setEditorData(QWidget*, const QModelIndex&) const’:
2025-04-29T21:26:40.1560564Z /run/build/mixxx/src/controllers/delegates/controldelegate.cpp:71:31: note: at offset 32 into object ‘<anonymous>’ of size 32
2025-04-29T21:26:40.1561889Z    71 |     ConfigKey key = index.data(Qt::EditRole).value<ConfigKey>();
2025-04-29T21:26:40.1562418Z       |                     ~~~~~~~~~~^~~~~~~~~~~~~~
2025-04-29T21:26:40.1563263Z In function ‘constexpr _Tp std::__exchange(_Tp&, _Up&&) [with _Tp = long long int; _Up = int]’,
2025-04-29T21:26:40.1564539Z     inlined from ‘constexpr _Tp std::exchange(_Tp&, _Up&&) [with _Tp = long long int; _Up = int]’ at /usr/include/c++/14.2.0/utility:110:29,
2025-04-29T21:26:40.1566135Z     inlined from ‘QArrayDataPointer<T>::QArrayDataPointer(QArrayDataPointer<T>&&) [with T = char16_t]’ at /usr/include/QtCore/qarraydatapointer.h:80:29,
2025-04-29T21:26:40.1567518Z     inlined from ‘QString::QString(QString&&)’ at /usr/include/QtCore/qstring.h:182:12,
2025-04-29T21:26:40.1568710Z     inlined from ‘ConfigKey::ConfigKey(ConfigKey&&)’ at /run/build/mixxx/src/preferences/configobject.h:18:7,
2025-04-29T21:26:40.1570112Z     inlined from ‘T qvariant_cast(QVariant&&) [with T = ConfigKey]’ at /usr/include/QtCore/qvariant.h:774:67,
2025-04-29T21:26:40.1571313Z     inlined from ‘T QVariant::value() && [with T = ConfigKey]’ at /usr/include/QtCore/qvariant.h:529:47,
2025-04-29T21:26:40.1573031Z     inlined from ‘virtual void ControlDelegate::setEditorData(QWidget*, const QModelIndex&) const’ at /run/build/mixxx/src/controllers/delegates/controldelegate.cpp:71:63:
2025-04-29T21:26:40.1574945Z /usr/include/c++/14.2.0/bits/move.h:176:11: warning: array subscript 5 is outside array bounds of ‘QVariant [1]’ [-Warray-bounds=]
2025-04-29T21:26:40.1575843Z   176 |       _Tp __old_val = std::move(__obj);
2025-04-29T21:26:40.1576254Z       |           ^~~~~~~~~
2025-04-29T21:26:40.1577678Z /run/build/mixxx/src/controllers/delegates/controldelegate.cpp: In member function ‘virtual void ControlDelegate::setEditorData(QWidget*, const QModelIndex&) const’:
2025-04-29T21:26:40.1602949Z /run/build/mixxx/src/controllers/delegates/controldelegate.cpp:71:31: note: at offset 40 into object ‘<anonymous>’ of size 32
2025-04-29T21:26:40.1604103Z    71 |     ConfigKey key = index.data(Qt::EditRole).value<ConfigKey>();
2025-04-29T21:26:40.1604574Z       |                     ~~~~~~~~~~^~~~~~~~~~~~~~
2025-04-29T21:26:40.1605409Z In function ‘constexpr _Tp std::__exchange(_Tp&, _Up&&) [with _Tp = long long int; _Up = int]’,
2025-04-29T21:26:40.1606573Z     inlined from ‘constexpr _Tp std::exchange(_Tp&, _Up&&) [with _Tp = long long int; _Up = int]’ at /usr/include/c++/14.2.0/utility:110:29,
2025-04-29T21:26:40.1608030Z     inlined from ‘QArrayDataPointer<T>::QArrayDataPointer(QArrayDataPointer<T>&&) [with T = char16_t]’ at /usr/include/QtCore/qarraydatapointer.h:80:29,
2025-04-29T21:26:40.1609225Z     inlined from ‘QString::QString(QString&&)’ at /usr/include/QtCore/qstring.h:182:12,
2025-04-29T21:26:40.1610476Z     inlined from ‘ConfigKey::ConfigKey(ConfigKey&&)’ at /run/build/mixxx/src/preferences/configobject.h:18:7,
2025-04-29T21:26:40.1611647Z     inlined from ‘T qvariant_cast(QVariant&&) [with T = ConfigKey]’ at /usr/include/QtCore/qvariant.h:774:67,
2025-04-29T21:26:40.1612715Z     inlined from ‘T QVariant::value() && [with T = ConfigKey]’ at /usr/include/QtCore/qvariant.h:529:47,
2025-04-29T21:26:40.1614221Z     inlined from ‘virtual void ControlDelegate::setEditorData(QWidget*, const QModelIndex&) const’ at /run/build/mixxx/src/controllers/delegates/controldelegate.cpp:71:63:
2025-04-29T21:26:40.1615939Z /usr/include/c++/14.2.0/bits/move.h:177:13: warning: array subscript 5 is outside array bounds of ‘QVariant [1]’ [-Warray-bounds=]
2025-04-29T21:26:40.1616787Z   177 |       __obj = std::forward<_Up>(__new_val);
2025-04-29T21:26:40.1617174Z       |       ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2025-04-29T21:26:40.1618520Z /run/build/mixxx/src/controllers/delegates/controldelegate.cpp: In member function ‘virtual void ControlDelegate::setEditorData(QWidget*, const QModelIndex&) const’:
2025-04-29T21:26:40.1620767Z /run/build/mixxx/src/controllers/delegates/controldelegate.cpp:71:31: note: at offset 40 into object ‘<anonymous>’ of size 32
2025-04-29T21:26:40.1621969Z    71 |     ConfigKey key = index.data(Qt::EditRole).value<ConfigKey>();
2025-04-29T21:26:40.1622462Z       |                     ~~~~~~~~~~^~~~~~~~~~~~~~
2025-04-29T21:26:41.9953897Z [216/982] Building CXX object CMakeFiles/mixxx-lib.dir/src/controllers/delegates/midibytedelegate.cpp.o
2025-04-29T21:26:43.3485681Z [217/982] Building CXX object CMakeFiles/mixxx-lib.dir/src/controllers/delegates/midichanneldelegate.cpp.o
2025-04-29T21:26:44.5266969Z [218/982] Building CXX object CMakeFiles/mixxx-lib.dir/src/controllers/controlpickermenu.cpp.o
2025-04-29T21:26:46.4165945Z [219/982] Building CXX object CMakeFiles/mixxx-lib.dir/src/controllers/delegates/midiopcodedelegate.cpp.o
2025-04-29T21:26:48.7990647Z [220/982] Building CXX object CMakeFiles/mixxx-lib.dir/src/controllers/delegates/midioptionsdelegate.cpp.o
2025-04-29T21:26:55.9184459Z [221/982] Building CXX object CMakeFiles/mixxx-lib.dir/src/controllers/dlgcontrollerlearning.cpp.o
2025-04-29T21:26:55.9193587Z In file included from /usr/include/c++/14.2.0/bits/stl_pair.h:61,
2025-04-29T21:26:55.9194765Z                  from /usr/include/c++/14.2.0/utility:69,
2025-04-29T21:26:55.9195248Z                  from /usr/include/QtCore/qglobal.h:15,
2025-04-29T21:26:55.9195753Z                  from /usr/include/QtGui/qtguiglobal.h:7,
2025-04-29T21:26:55.9196271Z                  from /usr/include/QtWidgets/qtwidgetsglobal.h:7,
2025-04-29T21:26:55.9196776Z                  from /usr/include/QtWidgets/qdialog.h:7,
2025-04-29T21:26:55.9197246Z                  from /usr/include/QtWidgets/QDialog:1,
2025-04-29T21:26:55.9197864Z                  from /run/build/mixxx/src/controllers/dlgcontrollerlearning.h:3,
2025-04-29T21:26:55.9198640Z                  from /run/build/mixxx/src/controllers/dlgcontrollerlearning.cpp:1:
2025-04-29T21:26:55.9200251Z In function ‘constexpr _Tp std::__exchange(_Tp&, _Up&&) [with _Tp = char16_t*; _Up = std::nullptr_t]’,
2025-04-29T21:26:55.9201675Z     inlined from ‘constexpr _Tp std::exchange(_Tp&, _Up&&) [with _Tp = char16_t*; _Up = std::nullptr_t]’ at /usr/include/c++/14.2.0/utility:110:29,
2025-04-29T21:26:55.9203434Z     inlined from ‘QArrayDataPointer<T>::QArrayDataPointer(QArrayDataPointer<T>&&) [with T = char16_t]’ at /usr/include/QtCore/qarraydatapointer.h:79:28,
2025-04-29T21:26:55.9204841Z     inlined from ‘QString::QString(QString&&)’ at /usr/include/QtCore/qstring.h:182:12,
2025-04-29T21:26:55.9206043Z     inlined from ‘ConfigKey::ConfigKey(ConfigKey&&)’ at /run/build/mixxx/src/preferences/configobject.h:18:7,
2025-04-29T21:26:55.9207317Z     inlined from ‘T qvariant_cast(QVariant&&) [with T = ConfigKey]’ at /usr/include/QtCore/qvariant.h:774:67,
2025-04-29T21:26:55.9208499Z     inlined from ‘T QVariant::value() && [with T = ConfigKey]’ at /usr/include/QtCore/qvariant.h:529:47,
2025-04-29T21:26:55.9210458Z     inlined from ‘void DlgControllerLearning::comboboxIndexChanged(int)’ at /run/build/mixxx/src/controllers/dlgcontrollerlearning.cpp:538:69:
2025-04-29T21:26:55.9212220Z /usr/include/c++/14.2.0/bits/move.h:176:11: warning: array subscript 4 is outside array bounds of ‘QVariant [1]’ [-Warray-bounds=]
2025-04-29T21:26:55.9213078Z   176 |       _Tp __old_val = std::move(__obj);
2025-04-29T21:26:55.9213461Z       |           ^~~~~~~~~
2025-04-29T21:26:55.9214611Z /run/build/mixxx/src/controllers/dlgcontrollerlearning.cpp: In member function ‘void DlgControllerLearning::comboboxIndexChanged(int)’:
2025-04-29T21:26:55.9216186Z /run/build/mixxx/src/controllers/dlgcontrollerlearning.cpp:538:44: note: at offset 32 into object ‘<anonymous>’ of size 32
2025-04-29T21:26:55.9217174Z   538 |             comboBoxChosenControl->itemData(index).value<ConfigKey>();
2025-04-29T21:26:55.9217712Z       |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
2025-04-29T21:26:55.9218524Z In function ‘constexpr _Tp std::__exchange(_Tp&, _Up&&) [with _Tp = char16_t*; _Up = std::nullptr_t]’,
2025-04-29T21:26:55.9222217Z     inlined from ‘constexpr _Tp std::exchange(_Tp&, _Up&&) [with _Tp = char16_t*; _Up = std::nullptr_t]’ at /usr/include/c++/14.2.0/utility:110:29,
2025-04-29T21:26:55.9223793Z     inlined from ‘QArrayDataPointer<T>::QArrayDataPointer(QArrayDataPointer<T>&&) [with T = char16_t]’ at /usr/include/QtCore/qarraydatapointer.h:79:28,
2025-04-29T21:26:55.9225098Z     inlined from ‘QString::QString(QString&&)’ at /usr/include/QtCore/qstring.h:182:12,
2025-04-29T21:26:55.9226356Z     inlined from ‘ConfigKey::ConfigKey(ConfigKey&&)’ at /run/build/mixxx/src/preferences/configobject.h:18:7,
2025-04-29T21:26:55.9227660Z     inlined from ‘T qvariant_cast(QVariant&&) [with T = ConfigKey]’ at /usr/include/QtCore/qvariant.h:774:67,
2025-04-29T21:26:55.9228936Z     inlined from ‘T QVariant::value() && [with T = ConfigKey]’ at /usr/include/QtCore/qvariant.h:529:47,
2025-04-29T21:26:55.9231184Z     inlined from ‘void DlgControllerLearning::comboboxIndexChanged(int)’ at /run/build/mixxx/src/controllers/dlgcontrollerlearning.cpp:538:69:
2025-04-29T21:26:55.9232933Z /usr/include/c++/14.2.0/bits/move.h:177:13: warning: array subscript 4 is outside array bounds of ‘QVariant [1]’ [-Warray-bounds=]
2025-04-29T21:26:55.9233893Z   177 |       __obj = std::forward<_Up>(__new_val);
2025-04-29T21:26:55.9234347Z       |       ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2025-04-29T21:26:55.9235715Z /run/build/mixxx/src/controllers/dlgcontrollerlearning.cpp: In member function ‘void DlgControllerLearning::comboboxIndexChanged(int)’:
2025-04-29T21:26:55.9237487Z /run/build/mixxx/src/controllers/dlgcontrollerlearning.cpp:538:44: note: at offset 32 into object ‘<anonymous>’ of size 32
2025-04-29T21:26:55.9238604Z   538 |             comboBoxChosenControl->itemData(index).value<ConfigKey>();
2025-04-29T21:26:55.9239200Z       |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
2025-04-29T21:26:55.9240299Z In function ‘constexpr _Tp std::__exchange(_Tp&, _Up&&) [with _Tp = long long int; _Up = int]’,
2025-04-29T21:26:55.9241636Z     inlined from ‘constexpr _Tp std::exchange(_Tp&, _Up&&) [with _Tp = long long int; _Up = int]’ at /usr/include/c++/14.2.0/utility:110:29,
2025-04-29T21:26:55.9281484Z     inlined from ‘QArrayDataPointer<T>::QArrayDataPointer(QArrayDataPointer<T>&&) [with T = char16_t]’ at /usr/include/QtCore/qarraydatapointer.h:80:29,
2025-04-29T21:26:55.9282918Z     inlined from ‘QString::QString(QString&&)’ at /usr/include/QtCore/qstring.h:182:12,
2025-04-29T21:26:55.9284102Z     inlined from ‘ConfigKey::ConfigKey(ConfigKey&&)’ at /run/build/mixxx/src/preferences/configobject.h:18:7,
2025-04-29T21:26:55.9285336Z     inlined from ‘T qvariant_cast(QVariant&&) [with T = ConfigKey]’ at /usr/include/QtCore/qvariant.h:774:67,
2025-04-29T21:26:55.9286467Z     inlined from ‘T QVariant::value() && [with T = ConfigKey]’ at /usr/include/QtCore/qvariant.h:529:47,
2025-04-29T21:26:55.9287955Z     inlined from ‘void DlgControllerLearning::comboboxIndexChanged(int)’ at /run/build/mixxx/src/controllers/dlgcontrollerlearning.cpp:538:69:
2025-04-29T21:26:55.9290070Z /usr/include/c++/14.2.0/bits/move.h:176:11: warning: array subscript 5 is outside array bounds of ‘QVariant [1]’ [-Warray-bounds=]
2025-04-29T21:26:55.9291125Z   176 |       _Tp __old_val = std::move(__obj);
2025-04-29T21:26:55.9291509Z       |           ^~~~~~~~~
2025-04-29T21:26:55.9292746Z /run/build/mixxx/src/controllers/dlgcontrollerlearning.cpp: In member function ‘void DlgControllerLearning::comboboxIndexChanged(int)’:
2025-04-29T21:26:55.9294429Z /run/build/mixxx/src/controllers/dlgcontrollerlearning.cpp:538:44: note: at offset 40 into object ‘<anonymous>’ of size 32
2025-04-29T21:26:55.9295485Z   538 |             comboBoxChosenControl->itemData(index).value<ConfigKey>();
2025-04-29T21:26:55.9296042Z       |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
2025-04-29T21:26:55.9296869Z In function ‘constexpr _Tp std::__exchange(_Tp&, _Up&&) [with _Tp = long long int; _Up = int]’,
2025-04-29T21:26:55.9298207Z     inlined from ‘constexpr _Tp std::exchange(_Tp&, _Up&&) [with _Tp = long long int; _Up = int]’ at /usr/include/c++/14.2.0/utility:110:29,
2025-04-29T21:26:55.9300299Z     inlined from ‘QArrayDataPointer<T>::QArrayDataPointer(QArrayDataPointer<T>&&) [with T = char16_t]’ at /usr/include/QtCore/qarraydatapointer.h:80:29,
2025-04-29T21:26:55.9301652Z     inlined from ‘QString::QString(QString&&)’ at /usr/include/QtCore/qstring.h:182:12,
2025-04-29T21:26:55.9302802Z     inlined from ‘ConfigKey::ConfigKey(ConfigKey&&)’ at /run/build/mixxx/src/preferences/configobject.h:18:7,
2025-04-29T21:26:55.9303994Z     inlined from ‘T qvariant_cast(QVariant&&) [with T = ConfigKey]’ at /usr/include/QtCore/qvariant.h:774:67,
2025-04-29T21:26:55.9305109Z     inlined from ‘T QVariant::value() && [with T = ConfigKey]’ at /usr/include/QtCore/qvariant.h:529:47,
2025-04-29T21:26:55.9306548Z     inlined from ‘void DlgControllerLearning::comboboxIndexChanged(int)’ at /run/build/mixxx/src/controllers/dlgcontrollerlearning.cpp:538:69:
2025-04-29T21:26:55.9308182Z /usr/include/c++/14.2.0/bits/move.h:177:13: warning: array subscript 5 is outside array bounds of ‘QVariant [1]’ [-Warray-bounds=]
2025-04-29T21:26:55.9309101Z   177 |       __obj = std::forward<_Up>(__new_val);
2025-04-29T21:26:55.9309718Z       |       ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2025-04-29T21:26:55.9311002Z /run/build/mixxx/src/controllers/dlgcontrollerlearning.cpp: In member function ‘void DlgControllerLearning::comboboxIndexChanged(int)’:
2025-04-29T21:26:55.9312764Z /run/build/mixxx/src/controllers/dlgcontrollerlearning.cpp:538:44: note: at offset 40 into object ‘<anonymous>’ of size 32
2025-04-29T21:26:55.9313882Z   538 |             comboBoxChosenControl->itemData(index).value<ConfigKey>();
2025-04-29T21:26:55.9314478Z       |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~

Version

2.5.1

OS

Ubuntu 24.04.2

[daschuer]

There are some more warnings like this:

2025-04-29T21:22:46.3802511Z In file included from /run/build/mixxx/lib/fidlib/fidlib.c:668:
2025-04-29T21:22:46.3803933Z In function ‘z2fidfilter’,
2025-04-29T21:22:46.3811200Z     inlined from ‘des_piz’ at /run/build/mixxx/lib/fidlib/fidlib.c:884:11:
2025-04-29T21:22:46.3813157Z /run/build/mixxx/lib/fidlib/fidmkf.h:737:11: warning: array subscript ‘FidFilter[4]’ is partly outside array bounds of ‘unsigned char[72]’ [-Warray-bounds=]
2025-04-29T21:22:46.3814474Z   737 |    ff->typ= 0;
2025-04-29T21:22:46.3814918Z       |    ~~~~~~~^~~
2025-04-29T21:22:46.3815295Z In function ‘Alloc’,
2025-04-29T21:22:46.3816632Z     inlined from ‘z2fidfilter’ at /run/build/mixxx/lib/fidlib/fidmkf.h:655:12,
2025-04-29T21:22:46.3817532Z     inlined from ‘des_piz’ at /run/build/mixxx/lib/fidlib/fidlib.c:884:11:
2025-04-29T21:22:46.3818651Z /run/build/mixxx/lib/fidlib/fidlib.c:325:14: note: at offset 64 into object of size 72 allocated by ‘calloc’
2025-04-29T21:22:46.3819864Z   325 |    void *vp= calloc(1, size);
2025-04-29T21:22:46.3820292Z       |              ^~~~~~~~~~~~~~~
2025-04-29T21:22:46.3820821Z In function ‘z2fidfilter’,
2025-04-29T21:22:46.3821545Z     inlined from ‘des_piz’ at /run/build/mixxx/lib/fidlib/fidlib.c:884:11:
2025-04-29T21:22:46.3823072Z /run/build/mixxx/lib/fidlib/fidmkf.h:738:11: warning: array subscript ‘FidFilter[4]’ is partly outside array bounds of ‘unsigned char[72]’ [-Warray-bounds=]
2025-04-29T21:22:46.3824138Z   738 |    ff->len= 0;
2025-04-29T21:22:46.3824448Z       |    ~~~~~~~^~~
2025-04-29T21:22:46.3824837Z In function ‘Alloc’,
2025-04-29T21:22:46.3825507Z     inlined from ‘z2fidfilter’ at /run/build/mixxx/lib/fidlib/fidmkf.h:655:12,
2025-04-29T21:22:46.3826427Z     inlined from ‘des_piz’ at /run/build/mixxx/lib/fidlib/fidlib.c:884:11:
2025-04-29T21:22:46.3827548Z /run/build/mixxx/lib/fidlib/fidlib.c:325:14: note: at offset 64 into object of size 72 allocated by ‘calloc’
2025-04-29T21:22:46.3828455Z   325 |    void *vp= calloc(1, size);
2025-04-29T21:22:46.3828855Z       |              ^~~~~~~~~~~~~~~
2025-04-29T21:22:46.3829328Z In function ‘z2fidfilter’,
2025-04-29T21:22:46.3830262Z     inlined from ‘des_pi’ at /run/build/mixxx/lib/fidlib/fidlib.c:871:11:
2025-04-29T21:22:46.3831679Z /run/build/mixxx/lib/fidlib/fidmkf.h:737:11: warning: array subscript ‘FidFilter[4]’ is partly outside array bounds of ‘unsigned char[72]’ [-Warray-bounds=]
2025-04-29T21:22:46.3832697Z   737 |    ff->typ= 0;
2025-04-29T21:22:46.3832990Z       |    ~~~~~~~^~~
2025-04-29T21:22:46.3833333Z In function ‘Alloc’,
2025-04-29T21:22:46.3833942Z     inlined from ‘z2fidfilter’ at /run/build/mixxx/lib/fidlib/fidmkf.h:655:12,
2025-04-29T21:22:46.3834765Z     inlined from ‘des_pi’ at /run/build/mixxx/lib/fidlib/fidlib.c:871:11:
2025-04-29T21:22:46.3835788Z /run/build/mixxx/lib/fidlib/fidlib.c:325:14: note: at offset 64 into object of size 72 allocated by ‘calloc’
2025-04-29T21:22:46.3836552Z   325 |    void *vp= calloc(1, size);
2025-04-29T21:22:46.3836916Z       |              ^~~~~~~~~~~~~~~
2025-04-29T21:22:46.3837335Z In function ‘z2fidfilter’,
2025-04-29T21:22:46.3838184Z     inlined from ‘des_pi’ at /run/build/mixxx/lib/fidlib/fidlib.c:871:11:
2025-04-29T21:22:46.3860761Z /run/build/mixxx/lib/fidlib/fidmkf.h:738:11: warning: array subscript ‘FidFilter[4]’ is partly outside array bounds of ‘unsigned char[72]’ [-Warray-bounds=]
2025-04-29T21:22:46.3862103Z   738 |    ff->len= 0;
2025-04-29T21:22:46.3862424Z       |    ~~~~~~~^~~
2025-04-29T21:22:46.3862838Z In function ‘Alloc’,
2025-04-29T21:22:46.3863501Z     inlined from ‘z2fidfilter’ at /run/build/mixxx/lib/fidlib/fidmkf.h:655:12,
2025-04-29T21:22:46.3864391Z     inlined from ‘des_pi’ at /run/build/mixxx/lib/fidlib/fidlib.c:871:11:
2025-04-29T21:22:46.3865479Z /run/build/mixxx/lib/fidlib/fidlib.c:325:14: note: at offset 64 into object of size 72 allocated by ‘calloc’
2025-04-29T21:22:46.3866289Z   325 |    void *vp= calloc(1, size);
2025-04-29T21:22:46.3866680Z       |              ^~~~~~~~~~~~~~~

[Swiftb0y]

There are likely two different warnings. The QVariant related ones are QTBUG-135623 are seemingly false positives. Not sure about the fidlib ones.

[Swiftb0y]

fyi it also happens on Fedora 43, so its just a matter of running on a recent enough gcc version.

[Swiftb0y]

Okay, I think i know what the issue is for fidlib. In the definition of FidFilter, it says int len; double val[1];. However, the doesn't actually treat this as an array of that size but rather as a variable size array (meaning fidlib allocates sizeof(FidFilter) values and len-1 doubles at the end (see FFALLOC macro)). While this works in practice, it's probably some form of undefined behavior so the compiler assumes val is really just a single double and thus warns when it sees out-of-bound accesses.

The fix here would probably to make val a proper "flexible member" https://en.cppreference.com/w/c/language/struct
That requires some careful testing and review though because it would change the sizeof(FidFilter). I don't want to do that though. The fidlib code is a tinderbox waiting to go up in flames...

[JoergAtGithub]

The fidlib code is a tinderbox waiting to go up in flames...

I suggest to replace fidlib with https://github.com/kfrlib/kfr

[daschuer]

It was a loooot of work to tweak the EQs based on fildlib. While replacing is appealing I don't see this and the related required testing happen anytime soon. From this point of view quick silencing or fixing the low hanging fruits is more straight forward for a stable 2.5.2 release.

[Swiftb0y]

if you just want to silence the warnings, you can use gcc/clang pragmas. I won't take responsibility for any UB that hides though.

[daschuer]

Yes that is of cause the last resort. At least it will not be a regression because the code has not been touched since long.

[Swiftb0y]

well it could be a regression when the issue is actually UB and a new compiler version starts optimizing due to that...

[Swiftb0y]

#14798

[daschuer]

The Qt bug is flagged as invalid. So there won't be any change. We may consider to poupate our code with scoped warray-bounds disable pragmas. The alternative is a compiler version dependent hack in CMakeLists.txt. I think we should go for the later.

[daschuer]

I have just tested the g++ 14.2.0-4ubuntu2 https://packages.ubuntu.com/noble/g++-14 that has incorporated some upstream patches. This is no longer affected, I can identify why though.
https://github.com/daschuer/mixxx/actions/runs/15386737624/job/43286809589
The fixed fidlib warnings are still there without #14798 so the -Warray-bounds=1 works.