Support non-JavaScript identifier token in default export#330
Conversation
🦋 Changeset detectedLatest commit: 8624e4d The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…namedExport` is false Co-Authored-By: Ryuya Yanagi <57742720+apple-yagi@users.noreply.github.com>
Co-Authored-By: Ryuya Yanagi <57742720+apple-yagi@users.noreply.github.com>
f8a82de to
e633dc7
Compare
| proxy.getCompletionEntryDetails = getCompletionEntryDetails(languageService, resolver, config); | ||
| proxy.getCodeFixesAtPosition = getCodeFixesAtPosition(language, languageService, project, resolver, config); | ||
| proxy.getDefinitionAndBoundSpan = getDefinitionAndBoundSpan(language, languageService); | ||
| proxy.findReferences = findReferences(languageService); |
There was a problem hiding this comment.
https://github.com/mizdra/css-modules-kit/pull/320/changes#diff-092ceede4ba31c22487aee4745cbd708001cd1fb391e45bb72c7f5429319d5fa applies a patch to getReferencesAtPosition. I'm unsure whether we should do the same in this PR.
This patch exists solely to pass tests. Typically, users won't encounter issues without it. The reason is explained at https://github.com/mizdra/css-modules-kit/pull/330/changes#diff-dfca5f15f8422ee53dd53de71429e82487d16f8582cbec09ee9943d5c8a84978R16-R20.
I plan to release without patching getReferencesAtPosition. If there are any issues, users will likely report bugs.
Co-Authored-By: Ryuya Yanagi <57742720+apple-yagi@users.noreply.github.com>
close: #323
Future Works
no-unused-class-namesreportsa-1as unused even though it is used instyles['a-1'].no-unused-class-namesrule should markstyles['foo']andstyles["foo"]as using class names #125Special Thanks
@apple-yagi created a proof of concept in #309 and #320, demonstrating that this feature is feasible. He also provided key ideas for implementing this feature, specifically the concept of multiple mapping objects, alongside me (ref: #309 (comment)). Thank you!