Docker 1.8 support - #540
Merged
Merged
Conversation
Copied original spec to keep all pre 1.8 tests even though most won't be affected by this. Doing a search of all 'Mounts' nodes from the inspect output for the given arguments. @mizzy suggested doing the fall-through inline instead of making it more complicated.
Owner
There was a problem hiding this comment.
This line is not needed bacuse private was called already.
Contributor
Author
|
Fixed the extra private. Did't know if you'd rather be more explicit |
Owner
|
Thanks! |
Owner
|
Released as v2.24.2. |
|
Hi, am thinking about adding more Docker matchers to
Want to ask for your thoughts before moving on, since I can see Docker support has been added a while ago but the number of matchers is limited. Is there a reason to that? Cheers, |
Owner
|
We can access all attributes of describe docker_container('foo') do
its(['HostConfig.RestartPolicy.MaximumRetryCount']) { should == 0 }
endI think we should use this syntax as much as possible. But if you think it's hard to write or hard to read about some attributes, then think about adding matchers. |
|
👍 yup, I guess that'll do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docker 1.8 changed the format of the json response of
docker inspectstarting in 1.8, specifically relating to volumes.Doing a check for the new node and asserting against that for the
has_volume?matcher, falling back to pre 1.8 if it's not found.