docs: use "us" as the example marketplace - #3
Merged
Conversation
us reads as the more international default than de, and it is what the audible-cli CI example already used. The value is quoted in the gh variable set example and in the prose that follows it, so a bare us cannot be read as the English word. The country-code enumeration is reordered to lead with us in both the README table and action.yml, so the two stay identical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1, kept separate because it also touches
action.yml.dewas a parochial choice for the one worked example.usreads as the more international default, and it is what the audible-cli CI example in mkb79/audible-cli#304 already used.The value is quoted —
--body "us", and"us"in the prose that follows — so a bareuscannot be misread as the English word.The
country-codeenumeration is reordered to lead withusin both the README table andaction.yml, so the two stay identical.Left alone on purpose:
scripts/configure.py, whose error message already leads withus.FAKE_COUNTRY_CODE: dein the test workflow, which is a fixture rather than documentation.